Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not Compatible with Superset Server Pagination Feature #29

Closed
cardilloscreations opened this issue Feb 18, 2025 · 2 comments
Closed

Not Compatible with Superset Server Pagination Feature #29

cardilloscreations opened this issue Feb 18, 2025 · 2 comments

Comments

@cardilloscreations
Copy link

cardilloscreations commented Feb 18, 2025

I believe the root cause is because they use OFFSET, but when I tried to enable this feature to allow more efficient database browsing through Superset, I cannot change pages and get an error about the OFFSET instead. This is like what was reported in issue #25 but that is broader (and includes reference to this problem from a pure SQLAlchemy point of view).

I'm opening this separate issue because it may be easier to solve in Superset specifically by providing the right dialect for the pagination using the special LIMIT keyword instead of OFFSET. If not, then perhaps that's feedback Superset needs to hear. If that ends up being the case, then resolving #25 should resolve this as well, because they're probably trying to use SQLAlchemy's offset as well.

Example of the error when trying to use Drill Into and then navigating to another page of the results:

Error: unexpected token [OFFSET]
LINE 10: OFFSET 50
         ^
@nwoolmer
Copy link
Contributor

Hey @cardilloscreations , please can you test this and then close if resolved.

We may add OFFSET to the SQL syntax for general compatibility in future.

@cardilloscreations
Copy link
Author

Just upgraded to 1.1.4 and confirmed that it's working properly now. Thanks! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants