Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingress pathType should be configurable #154

Closed
svils opened this issue Apr 29, 2024 · 2 comments
Closed

Ingress pathType should be configurable #154

svils opened this issue Apr 29, 2024 · 2 comments

Comments

@svils
Copy link
Contributor

svils commented Apr 29, 2024

Description:

The current Helm chart contains hardcoded pathType for ingress paths, set to "ImplementationSpecific". This limits flexibility and adaptability to different deployment scenarios, particularly when deploying in environments that require a specific pathType (such as "Prefix" or "Exact").

Environment:

Kubernetes Version: v1.2.9
Chart Name: questdb

Expected Behavior:

Users should be able to specify a pathType for each ingress path directly in the values.yaml file, allowing for customized ingress behavior based on the deployment needs.

Actual Behavior:

The pathType is currently hardcoded and not configurable, which can lead to suboptimal configurations in environments with specific ingress requirements. For example when using ALB controller and hardcoded values the UI is not reachable.

Proposed Solution:

Modify the Helm template to include a configurable pathType per ingress path. This change will allow to define the desired pathType in the values.yaml file. Example:

ingress:
  hosts:
    - host: example.com
      paths:
        - path: /
          pathType: ImplementationSpecific

Willingness to Contribute:

I am willing to work on this issue and submit a pull request with the necessary changes. I look forward to feedback and any specific requirements or suggestions.

@sklarsa
Copy link
Contributor

sklarsa commented Apr 29, 2024

Thanks for opening the issue! We try to make this helm chart as flexible as possible, so if you have any changes that you can make to help it run in your environment, we'd happily review a PR and incorporate the changes

@sklarsa
Copy link
Contributor

sklarsa commented Apr 30, 2024

chart version 0.40.2 should now be available to download and use

@sklarsa sklarsa closed this as completed Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants