Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web console doesn't always highlight correct error position #40

Open
bziobrowski opened this issue Feb 23, 2022 · 2 comments
Open

Web console doesn't always highlight correct error position #40

bziobrowski opened this issue Feb 23, 2022 · 2 comments
Labels
bug Something isn't working web-console Issues relevant to "web-console" package

Comments

@bziobrowski
Copy link
Contributor

Describe the bug

For some SQLs web console doesn't mark proper error position returned by backend .

To reproduce

  1. Open web console
  2. Execute
    select * from long_sequence(1) where cast(x as timestamp) = '2012-04-12T12:00:0A'
  3. Check that error marker is at start of line

Expected Behavior

Web console should mark problmatic timestamp literal - either whole or start or end.

Environment

- **QuestDB version**: latest 6.2.1 master
- **OS**: Windows
- **Browser**: Chrome

Additional context

No response

@bziobrowski bziobrowski added the bug Something isn't working label Feb 23, 2022
@hezean
Copy link
Contributor

hezean commented May 28, 2022

A guess: the problem was caused by monaco-editor API's getWordAtPosition, which cuts the word '2012-04-12T12:00:0A' on the first dash.

Another example:
Screen Shot 2022-05-29 at 02 13 29

https://github.com/questdb/questdb/blob/37432fc6090de1d882ca278d365924f1a488e530/ui/src/scenes/Editor/Monaco/utils.ts#L217-L224

Could anyone kindly point out the next step? I'm not familiar with monaco -- maybe there are other APIs, or may set - as escaped from splitting.

@argshook argshook transferred this issue from questdb/questdb Sep 30, 2022
@argshook argshook added the web-console Issues relevant to "web-console" package label Sep 30, 2022
@argshook
Copy link
Contributor

Also reported here: #71

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working web-console Issues relevant to "web-console" package
Projects
None yet
Development

No branches or pull requests

3 participants