Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Console] Improve i18n for notifications #60

Closed
mpsq opened this issue Jun 19, 2020 · 6 comments · Fixed by #207
Closed

[Console] Improve i18n for notifications #60

mpsq opened this issue Jun 19, 2020 · 6 comments · Fixed by #207
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Eligible for Hacktoberfest 2023!~ web-console Issues relevant to "web-console" package

Comments

@mpsq
Copy link
Contributor

mpsq commented Jun 19, 2020

Currently, notifications show time in the format HH:MM:SS:

2020-06-19-153902_grim

We want instead to check the browser locales and display the time according to the user location/preferences. Date formatting should be done either natively (i18n module, cf. here for documentation) or via date-fns.

@mpsq mpsq added enhancement New feature or request good first issue Good for newcomers labels Jun 19, 2020
@argshook argshook transferred this issue from questdb/questdb Sep 30, 2022
@argshook argshook added the web-console Issues relevant to "web-console" package label Sep 30, 2022
@goodroot goodroot added the hacktoberfest Eligible for Hacktoberfest 2023!~ label Oct 3, 2023
@ManasMadan
Copy link

@mpsq Please assign this issue to me under hacktoberfest 2023. I Have Worked with i18n and date-fns before.
Thanks !

@msk4862
Copy link
Contributor

msk4862 commented Oct 13, 2023

@mpsq Gave it a try and raised a PR for this: #207
Can you please take a look?

@oliver-daniel
Copy link
Contributor

oliver-daniel commented Oct 13, 2023

Hey @msk4862! Thanks for your PR. Be advised that the most active maintainers of this repo are (in no particular order) myself, @argshook and @insmac.

@ManasMadan, sincere apologies for not getting to your comment sooner. If you're interested, I have another task in mind that surrounds date-fns and i18n that would be suitable for your experience, and may slot in well with Shoaib's contribution. Would you like me to describe it to you, and if you're interested, set up an issue and assign it to you?

Happy Hacktober!

@ManasMadan
Copy link

@oliver-daniel No worries I would love to work on a issue

@oliver-daniel
Copy link
Contributor

Hey @ManasMadan, thanks for your patience!

What do you think of working on the functionality of the Chart panel, as in #45?

To keep the scope of your work doable within Hacktober, I would recommend either working on the fix described in the issue, or laying out another singular improvement. For example, if you'd like to continue in the timestamp area, I'd personally be thrilled to see the ability to modify the format of charted timestamps.
I'm happy to work with you to lay out the scope of your contribution.

@ManasMadan
Copy link

@oliver-daniel I can work with the timestamp format thing.
after that i can work on issue #45 if someone does not complete it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Eligible for Hacktoberfest 2023!~ web-console Issues relevant to "web-console" package
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants