Skip to content

Wrap Criteria is and regex comparison if necessary. #4862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Wrap Criteria is and regex comparison if necessary. #4862

wants to merge 2 commits into from

Conversation

christophstrobl
Copy link
Member

@christophstrobl christophstrobl commented Dec 20, 2024 •
edited
Loading

This PR wraps simple values and Patterns to avoid creating invalid query objects.

Closes: #4850

@christophstrobl
Prepare issue branch.
d77786d
@christophstrobl
Wrap Criteria is and regex comparison if necessary.
cb40b69 
This commit wraps simple values and Patterns if to avoid creating invalid query objects.
mp911de pushed a commit that referenced this pull request Jan 7, 2025
@christophstrobl @mp911de
Wrap Criteria is and regex comparison if necessary.
1eca350 
This commit wraps simple values and Patterns if to avoid creating invalid query objects.

Original pull request: #4862
Closes #4850
mp911de added a commit that referenced this pull request Jan 7, 2025
@mp911de
Polishing.
fea69da 
Reduce test class and method visibility. Convert JUnit 4 test to JUnit 5. Reformat code.

Original pull request: #4862
See #4850
mp911de pushed a commit that referenced this pull request Jan 7, 2025
@christophstrobl @mp911de
Wrap Criteria is and regex comparison if necessary.
91c6fcd 
This commit wraps simple values and Patterns if to avoid creating invalid query objects.

Original pull request: #4862
Closes #4850
mp911de added a commit that referenced this pull request Jan 7, 2025
@mp911de
Polishing.
a113240 
Reduce test class and method visibility. Convert JUnit 4 test to JUnit 5. Reformat code.

Original pull request: #4862
See #4850
mp911de pushed a commit that referenced this pull request Jan 7, 2025
@christophstrobl @mp911de
Wrap Criteria is and regex comparison if necessary.
da5c062 
This commit wraps simple values and Patterns if to avoid creating invalid query objects.

Original pull request: #4862
Closes #4850
mp911de added a commit that referenced this pull request Jan 7, 2025
@mp911de
Polishing.
4e6ff39 
Reduce test class and method visibility. Convert JUnit 4 test to JUnit 5. Reformat code.

Original pull request: #4862
See #4850
@mp911de mp911de added the type: bug A general bug label Jan 7, 2025
@mp911de mp911de added this to the 4.3.8 (2024.0.8) milestone Jan 7, 2025
@mp911de mp911de closed this Jan 7, 2025
@mp911de mp911de deleted the issue/4850 branch January 7, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type: bug A general bug
Projects
None yet
Milestone
4.3.8 (2024.0.8)
Development

Successfully merging this pull request may close these issues.

Criteria with is and another filter for the same field creates invalid query doucment
2 participants
@christophstrobl @mp911de