Skip to content

Add query sort parameter for updateFirst method. #4888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add query sort parameter for updateFirst method. #4888

wants to merge 1 commit into from

Conversation

florianluediger
Copy link
Contributor

Closes #4797

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 29, 2025
@florianluediger
Copy link
Contributor Author

florianluediger commented Jan 29, 2025 •
edited
Loading

Hm, I have multiple email addresses in my GitHub account and the DCO check only seems to check for my companies mail address. I would like to use my private address, which is also set as the public address in my profile. Is that possible or should I just sign off with my companies mail?

Fixed. My bad, sorry.

Thanks for looking into my PR btw.

@florianluediger
Add query sort parameter for updateFirst method.
d890694 
Closes spring-projects#4797

Signed-off-by: Florian Lüdiger <florian.luediger@googlemail.com>
@mp911de mp911de added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 3, 2025
@florianluediger
Copy link
Contributor Author

@christophstrobl did you have time to look into my PR yet?

@christophstrobl
Copy link
Member

@florianluediger it's on the list. might take some time though till I get to it.

@christophstrobl
Copy link
Member

Thank you @florianluediger for your patience. I've slightly revised the PR to make sure @Field mapping information is considered. Also worked through bulk and replace operations to make sure sort is considered there as well.

christophstrobl pushed a commit that referenced this pull request Mar 4, 2025
@florianluediger @christophstrobl
Add query sort parameter for updateFirst method.
019d915 
Closes: #4797
Original Pull Request: #4888

Signed-off-by: Florian Lüdiger <florian.luediger@googlemail.com>
christophstrobl added a commit that referenced this pull request Mar 4, 2025
@christophstrobl
Apply sort to replace and bulk operation updates
d79031b 
Allow using sort parameter from the query for template replace as well as bulk update & replace operations.
We now also mapped fields used in sort to the domain type considering field annotations.
Also updated javadoc and reference documentation.

Original Pull Request: #4888
@christophstrobl
Copy link
Member

Thank you @florianluediger for you contribution. Merged to main development line.

@christophstrobl christophstrobl added this to the 4.5 M2 (2025.0.0) milestone Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@christophstrobl christophstrobl

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
4.5 M2 (2025.0.0)
Development

Successfully merging this pull request may close these issues.

Allow query sort parameter for updateFirst method on MongoDB Server 8.0
4 participants
@florianluediger @christophstrobl @mp911de @spring-projects-issues