Skip to content

chore: resolve lint errors in random/base/minstd #6498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 2, 2025

Conversation

impawstarlight
Copy link
Contributor

@impawstarlight impawstarlight commented Apr 1, 2025

Resolves none.

Description

What is the purpose of this pull request?

This pull request:

  • Resolves some lint errors and a syntax error in random/base/minstd.

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

Why is new Array(1e3) is flagged by the linter? Are there any better way to define an array of a given size?

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Apr 1, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Apr 1, 2025

Coverage Report

Package Statements Branches Functions Lines
random/base/minstd 627 / 627
+ 100.00 %
68 / 68
+ 100.00 %
12 / 12
+ 100.00 %
627 / 627
+ 100.00 %

The above coverage report was generated for the changes in this PR.

@impawstarlight impawstarlight changed the title fix: resolve lint errors in random/base/minstd chore: resolve lint errors in random/base/minstd Apr 1, 2025
Signed-off-by: Athan <kgryte@gmail.com>
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after refactoring to use @stdlib/array/base/zeros for generic array allocation, which is appropriate for this use case.

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Apr 2, 2025
@kgryte kgryte merged commit 8805742 into stdlib-js:develop Apr 2, 2025
11 checks passed
@impawstarlight impawstarlight deleted the fix/minstd branch April 2, 2025 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants