-
-
Notifications
You must be signed in to change notification settings - Fork 699
fix invalid yaml in rules globs #1833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
WalkthroughThe change updates the configuration in Changes
Possibly related PRs
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -1,5 +1,5 @@ | |||
--- | |||
globs: **/trigger/**/*.ts, **/trigger/**/*.tsx,**/trigger/**/*.js,**/trigger/**/*.jsx | |||
globs: [ '**/trigger/**/*.ts', '**/trigger/**/*.tsx', '**/trigger/**/*.js', '**/trigger/**/*.jsx' ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Convert globs
to a Valid YAML Array
The updated globs
property now uses a YAML array of strings instead of a comma-separated string, which resolves the invalid YAML issue and improves readability. Ensure that any tools or scripts parsing this configuration are updated to work with the array format.
Please ignore this I was confused |
Just saw your blog post and noticed the frontmatter isn't quite correct.
I've also asked on the cursor forum to verify this but essentially the format for the globs is invalid YAML currently
Summary by CodeRabbit