Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: View switcher should close after view switch #11154

Merged
merged 2 commits into from
Mar 26, 2025

Conversation

Nabhag8848
Copy link
Contributor

@Nabhag8848
Copy link
Contributor Author

@CoreTeamTwenty

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR adds functionality to automatically close the view picker dropdown menu after selecting a view, improving the user experience by addressing the issue of the menu staying open after selection.

  • Modified packages/twenty-front/src/modules/views/view-picker/components/ViewPickerListContent.tsx to call closeDropdown() after changeView() in handleViewSelect function
  • Added useDropdown hook with VIEW_PICKER_DROPDOWN_ID to manage dropdown state

💡 (3/5) Reply to the bot's comments like "Can you suggest a fix for this @greptileai?" or ask follow-up questions!

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link
Contributor

@ehconitin ehconitin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @Nabhag8848

Copy link
Member

@charlesBochet charlesBochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you @Nabhag8848

@charlesBochet charlesBochet merged commit 589b4cf into twentyhq:main Mar 26, 2025
45 checks passed
Copy link
Contributor

Thanks @Nabhag8848 for your contribution!
This marks your 22nd PR on the repo. You're top 2% of all our contributors 🎉
See contributor page - Share on LinkedIn - Share on Twitter

Contributions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

View switcher should close after view switch
3 participants