Option-menu-switch-table-kanban #11167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-menu-switch-table-kanban
…-menu-switch-table-kanban
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Enhanced the object options dropdown menu with table/kanban view switching capabilities and improved record grouping functionality.
- Added new
useObjectOptionsForLayouthook in/packages/twenty-front/src/modules/object-record/object-options-dropdown/hooks/useObjectOptionsForLayout.tsto manage view type transitions - Implemented automatic field selection for Kanban view in
ObjectOptionsDropdownLayoutContent.tsxwith fallback messaging when no select fields are available - Added conditional rendering for Kanban-specific options (compact view, grouping) in
/packages/twenty-front/src/modules/object-record/object-options-dropdown/components/ObjectOptionsDropdownLayoutContent.tsx - Enhanced group visibility controls and reordering functionality in
ObjectOptionsDropdownRecordGroupsContent.tsx
4 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
...y-front/src/modules/object-record/object-options-dropdown/hooks/useObjectOptionsForLayout.ts
Outdated
Show resolved
Hide resolved
...ules/object-record/object-options-dropdown/components/ObjectOptionsDropdownLayoutContent.tsx
Outdated
Show resolved
Hide resolved
...y-front/src/modules/object-record/object-options-dropdown/hooks/useObjectOptionsForLayout.ts
Outdated
Show resolved
Hide resolved
...y-front/src/modules/object-record/object-options-dropdown/hooks/useObjectOptionsForLayout.ts
Show resolved
Hide resolved
...y-front/src/modules/object-record/object-options-dropdown/hooks/useObjectOptionsForLayout.ts
Outdated
Show resolved
Hide resolved
...y-front/src/modules/object-record/object-options-dropdown/hooks/useObjectOptionsForLayout.ts
Outdated
Show resolved
Hide resolved
...y-front/src/modules/object-record/object-options-dropdown/hooks/useObjectOptionsForLayout.ts
Outdated
Show resolved
Hide resolved
...ules/object-record/object-options-dropdown/components/ObjectOptionsDropdownLayoutContent.tsx
Outdated
Show resolved
Hide resolved
ijreilly
reviewed
Mar 27, 2025
| switch (viewType) { | ||
| case ViewType.Kanban: { | ||
| if (availableFieldsForKanban.length === 0) { | ||
| throw new Error('No fields for kanban - should not happen'); |
There was a problem hiding this comment.
Not sure that we want to show users a message containing "should not happen", that's not very helpful for them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New options menu feature: table/kanban switching
This feature is the last one of the Optino Menu v2 update. It is designed to enable the possibility to switch from table to kanban and vice-versa.
Only the default tab is not editable for consitency in the UX of the application as designed by our team