Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scripts: migrate unpack-next to TypeScript #77538

Open
wants to merge 1 commit into
base: graphite-base/77538
Choose a base branch
from
Open

Scripts: migrate unpack-next to TypeScript #77538

wants to merge 1 commit into from

Conversation

wbinnssmith
Copy link
Member

@wbinnssmith wbinnssmith commented Mar 27, 2025 •
edited
Loading

Convert unpack-next.cjs to TypeScript

What?

Converted scripts/unpack-next.cjs to TypeScript, renaming it to scripts/unpack-next.ts and updating the imports and type definitions.

Why?

This change continues the ongoing TypeScript migration efforts in the codebase, providing better type safety and developer experience.

How?

  • Renamed file from .cjs to .ts
  • Converted CommonJS require() statements to ES module import statements
  • Added type annotation for the path parameter in the realPathIfAny function

Fixes #

@ijjk ijjk added the created-by: Turbopack team PRs by the Turbopack team. label Mar 27, 2025
@wbinnssmith Graphite App
Copy link
Member Author

wbinnssmith commented Mar 27, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@wbinnssmith wbinnssmith mentioned this pull request Mar 27, 2025
Merged
@bgw bgw changed the base branch from pack-next-refactor to graphite-base/77538 March 28, 2025 21:11
@wbinnssmith wbinnssmith marked this pull request as ready for review March 28, 2025 22:53
@wbinnssmith wbinnssmith changed the base branch from graphite-base/77538 to canary March 28, 2025 23:10
@wbinnssmith wbinnssmith changed the base branch from canary to graphite-base/77538 March 28, 2025 23:11
@graphite-app Graphite App
Copy link

graphite-app bot commented Mar 28, 2025 •
edited
Loading

Merge activity

  • Mar 28, 7:26 PM EDT: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..
  • Mar 28, 7:28 PM EDT: Graphite disabled "merge when ready" on this PR due to: Unknown error.

@wbinnssmith wbinnssmith changed the base branch from graphite-base/77538 to canary March 29, 2025 02:07
@wbinnssmith wbinnssmith changed the base branch from canary to graphite-base/77538 March 29, 2025 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgw bgw

Assignees
No one assigned
Labels
created-by: Turbopack team PRs by the Turbopack team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wbinnssmith @bgw @ijjk