Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply :duration property for list transition, fixes #10626 #10627

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

yukukotani
Copy link

@yukukotani yukukotani commented Oct 13, 2019

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • [] Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
duration property for transition-group component accepts a value with type object, string, or number.
If it's object, you can apply like { enter: 500, leave: 800, move: 300 } in ms. In case of string or number, you can just specify duration like 500 as same as transition component.

Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few syntaxes that should be supported and testcases should also be included, so this is a bit longer than it looks like. You can inspire yourself from #4857

@yukukotani yukukotani requested a review from posva October 26, 2019 18:42
@yukukotani
Copy link
Author

@posva Done!

@yukukotani yukukotani requested a review from Justineo November 7, 2019 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants