Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove scroll delay in AgendaList #2623

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

nitzanyiz
Copy link
Contributor

@nitzanyiz nitzanyiz commented Mar 25, 2025

Removed scroll delay in AgendaList and InfiniteList AgendaList.

Ticket:
MADS-4420

@nitzanyiz nitzanyiz requested review from Inbal-Tish and removed request for Inbal-Tish March 25, 2025 12:04
@nitzanyiz nitzanyiz requested a review from Inbal-Tish March 26, 2025 13:06
@nitzanyiz nitzanyiz marked this pull request as ready for review March 26, 2025 13:06
@nitzanyiz nitzanyiz changed the title Lowered scroll delay in AgendaList Remove scroll delay in AgendaList Mar 26, 2025
@@ -142,7 +141,7 @@ const AgendaList = forwardRef((props: AgendaListProps, ref: any) => {
return sectionTitle;
}, []);

const scrollToSection = useCallback(debounce((d) => {
const scrollToSection = useCallback((d) => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we discussed, removing the debounce only going to cause an issue with the list's updates from others source. Let's add the option to control this debounce time

@Inbal-Tish Inbal-Tish assigned nitzanyiz and unassigned Inbal-Tish Mar 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants