Improve Regex syntax highlighting #25332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
This was referenced Feb 21, 2025
maxdeviant
added a commit
that referenced
this pull request
Feb 21, 2025
Release Notes: - Improved JavaScript and TypeScript syntax highlighting. | Zed 0.174.6 | With this PR | | --- | --- | |  |  | - `regex_flags`: `keyword.regex`, see the [Regex PR](#25332) for other Regex scopes - `@`: `punctuation.special`, as in Python - `jsx_text`: `text.jsx` - `=`: `operator` -> `punctuation.jsx.delimiter`, `punctuation` as in [VS Code](https://github.com/microsoft/vscode/blob/0fe195613ed9901f669cd0f799fe807f0189d029/extensions/html/syntaxes/html.tmLanguage.json#L78) and [Atom](https://github.com/atom/language-html/blob/ee750a014a003c3d6f10b91e3cd5f9bfa0f051e6/grammars/tree-sitter-html.cson#L47) - added `jsx` scope to target JSX tokens specifically ```javascript /** * @Keyword comment */ @log class X { render() { return ( <div jsx_attribute="value"> <Input onKeyPress={super.bind(this)}/> jsx_text </div> ); } } const IDENTIFIER = true ``` --------- Co-authored-by: Marshall Bowers <git@maxdeviant.com>
|
After @ConradIrwin's 6faa7cd, now we don't see the text as green:
I'm finding a little weird having the enclosing @ConradIrwin @chbk @maxdeviant thoughts? |
|
no strong opinion; feel free to change it. One thing to note is that we use the regex highlighting in the search box, so needs to work in both contexts. |
|
Alright! I think the current version is looking decent in both search box and normal editor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes:
(?P=,<:punctuation.bracketgroup_name:property->label^,$:string.escape->operator\b,\B,\k:string.escape->keyword.operatorregexscope to target regex tokens specifically