Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vim: Add :w <filename> #27287

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

vim: Add :w <filename> #27287

wants to merge 1 commit into from

Conversation

AidanV
Copy link
Contributor

@AidanV AidanV commented Mar 22, 2025

Closes #10920

Release Notes:

  • vim: Adds support for :w[rite] <filename>

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Mar 22, 2025
@maxdeviant maxdeviant changed the title vim: :w <filename> vim: Add :w <filename> Mar 22, 2025
@ConradIrwin ConradIrwin self-assigned this Mar 22, 2025
@ConradIrwin
Copy link
Member

Thanks for this!

I don't think we should add this as an argument to SaveIntent, which is already pretty complicated, but instead use an internal vim action that calls save_as on the editor directly (and which errors if the file already exists).

I'd also really like to support filename completion here, but I don't think that needs to block.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support :w <filename> to Vim mode when saving
2 participants