Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debugger: Improve variable list keyboard navigation #27308

Conversation

RemcoSmitsDev
Copy link
Contributor

@RemcoSmitsDev RemcoSmitsDev commented Mar 22, 2025

This PR improves the keyboard navigation for the variable list.
Before this PR, if you want to open/close nested variables, you had to use the right/left & up/down arrow keys.
Now you can step through with just only using your left/right arrow keys, this feels a bit more natural and more similar to how other editors allow you to navigate through variables.

This PR also fixes the following issues:

  • Allow selecting a scope to be the start of your selection
  • Allow selecting previous item if the first item is selected

Screen.Recording.2025-03-22.at.14.34.18.mov

Release Notes:

  • N/A

Before this commit, you could not just only navigate through the
variable list with right and left arrow key. Now you can :) This commit
also fixes an issue when you have the first entry selected that we
didn't select the last entry if you hit the `select previous` action.
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Mar 22, 2025
@RemcoSmitsDev

This comment was marked as resolved.

@RemcoSmitsDev RemcoSmitsDev force-pushed the improve-variable-list-keyboard-navigation branch from 9f3cef4 to a66d78d Compare March 24, 2025 20:49
@osiewicz osiewicz merged commit bcfc9e4 into zed-industries:main Mar 24, 2025
15 checks passed
@osiewicz
Copy link
Contributor

Thanks!

@RemcoSmitsDev RemcoSmitsDev deleted the improve-variable-list-keyboard-navigation branch March 24, 2025 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants