Skip to content

fix: Prevent Chrome from autofilling password in search and API key inputs #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2025

Conversation

Gerrit1999
Copy link
Contributor

@Gerrit1999 Gerrit1999 commented Jul 15, 2025

fix: Prevent Chrome from autofilling password in search and API key inputs (#182)

This PR addresses the issue where Chrome browser automatically fills in login passwords into the "Search Provider" input box and the API Key input field in the LLM settings page.

To resolve this, autoComplete attributes have been added to the respective Input components in web/src/pages/llm/llm-settings.tsx:

  • The "Search Provider" input now has autoComplete="off".
  • The API Key input now has autoComplete="new-password".

Closes #182.

Summary by Sourcery

Prevent Chrome from autofilling passwords into the search provider and API key fields.

Bug Fixes:

  • Add autoComplete="off" to the search provider input to disable Chrome autofill.
  • Set autoComplete="new-password" on the API key input to prevent browser password suggestions.

Copy link
Contributor

sourcery-ai bot commented Jul 15, 2025

Reviewer's Guide

Disable Chrome autofill on the Search Provider and API Key fields by adding appropriate autoComplete attributes.

File-Level Changes

Change Details Files
Disable Chrome autofill on Search Provider and API Key inputs
  • Add autoComplete="off" to the Search Provider input component
  • Add autoComplete="new-password" to the API Key input component
web/src/pages/llm/llm-settings.tsx

Assessment against linked issues

Issue Objective Addressed Explanation
#182 Prevent Chrome from automatically filling the username/password in the 'Search Provider' input box on the LLM settings page.
#182 Prevent Chrome from automatically filling the username/password in the API Key input field on the LLM settings page.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Gerrit1999 - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@iFurySt iFurySt force-pushed the main branch 3 times, most recently from a6483bd to 35748c4 Compare July 16, 2025 06:35
Copy link
Member

@iFurySt iFurySt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! thanks!

@iFurySt iFurySt merged commit 6ddf080 into AmoyLab:main Jul 16, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] 在LLM设置页面 chrome浏览器输入框会每次都自动填充记住密码的用户名
2 participants