-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Sandcastle dev deployment #12680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sandcastle dev deployment #12680
Conversation
Thank you for the pull request, @jjspace! ✅ We can confirm we have a CLA on file for you. |
.github/workflows/sandcastle-dev.yml
Outdated
- name: deploy to dev-sandcastle.cesium.com | ||
if: ${{ env.AWS_ACCESS_KEY_ID != '' }} | ||
run: | | ||
curl -LO $(curl https://api.github.com/repos/CesiumGS/cesium/releases/latest -H "Authorization: ${GITHUB_TOKEN}" | jq -r '.assets[0].browser_download_url') | ||
unzip Cesium-$(cat package.json | jq -r '.version' | sed 's/\.0$//').zip -d Build/release/ -x "Apps" | ||
aws s3 sync Build/Sandcastle2/ s3://cesium-dev-sandcastle-website/ --cache-control "public, max-age=1800" --delete |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the vite build is bundling a copy of CesiumJS already. Is there a reason we are doing that and then pulling another copy of the latest version from github?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simply because it was in the prod deploy workflow I copied from. Confirmed it's not needed and removed 👍
1ae5b15
to
7f476c8
Compare
@ggetz I think this should be good to go now. In testing the last change I realized we had no way to tell what "version" of the code was running or when the server cache was updated. I added a very quick commit hash to the top right as a short term solution. We can figure out a better way to display the version later, todo added to the main list. |
Sounds good, thanks @jjspace! |
Description
Set up CI deployment of the new version of sandcastle to
https://dev-sandcastle.cesium.com/
. I set this to only run on thesandcastle-v2
branch which acts as the "base" feature branch for all of the Sandcastle rebuild. That said the vite configs and other changes rely on the updated logic in other open PRs like #12639 and #12631 so it can't be merged until they are.I did run the CI job once on this branch and confirmed it does work and there's now a version of the new sandcastle at https://dev-sandcastle.cesium.com/
Issue number and link
Part of #12566
Testing plan
Make sure Sandcastle is on https://dev-sandcastle.cesium.com/
To test the prod build run
npm run build-prod
in the package directoryThen run
npx http-server
in the/Build/Sandcastle2
directory. This directory should contain copies of all files needed for Sandcastle and run in "isolation" if you copied it to another directoryAuthor checklist
CONTRIBUTORS.md
CHANGES.md
with a short summary of my change