Skip to content

Sandcastle dev deployment #12680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 7, 2025
Merged

Sandcastle dev deployment #12680

merged 8 commits into from
Jul 7, 2025

Conversation

jjspace
Copy link
Contributor

@jjspace jjspace commented Jun 18, 2025

Description

Set up CI deployment of the new version of sandcastle to https://dev-sandcastle.cesium.com/. I set this to only run on the sandcastle-v2 branch which acts as the "base" feature branch for all of the Sandcastle rebuild. That said the vite configs and other changes rely on the updated logic in other open PRs like #12639 and #12631 so it can't be merged until they are.

I did run the CI job once on this branch and confirmed it does work and there's now a version of the new sandcastle at https://dev-sandcastle.cesium.com/

Issue number and link

Part of #12566

Testing plan

Make sure Sandcastle is on https://dev-sandcastle.cesium.com/

To test the prod build run npm run build-prod in the package directory
Then run npx http-server in the /Build/Sandcastle2 directory. This directory should contain copies of all files needed for Sandcastle and run in "isolation" if you copied it to another directory

Author checklist

  • I have submitted a Contributor License Agreement
  • I have added my name to CONTRIBUTORS.md
  • I have updated CHANGES.md with a short summary of my change
  • I have added or updated unit tests to ensure consistent code coverage
  • I have updated the inline documentation, and included code examples where relevant
  • I have performed a self-review of my code

@jjspace jjspace requested a review from ggetz June 18, 2025 20:07
Copy link

Thank you for the pull request, @jjspace!

✅ We can confirm we have a CLA on file for you.

Base automatically changed from sandcastle-react-structure to sandcastle-v2 June 27, 2025 19:45
Comment on lines 48 to 53
- name: deploy to dev-sandcastle.cesium.com
if: ${{ env.AWS_ACCESS_KEY_ID != '' }}
run: |
curl -LO $(curl https://api.github.com/repos/CesiumGS/cesium/releases/latest -H "Authorization: ${GITHUB_TOKEN}" | jq -r '.assets[0].browser_download_url')
unzip Cesium-$(cat package.json | jq -r '.version' | sed 's/\.0$//').zip -d Build/release/ -x "Apps"
aws s3 sync Build/Sandcastle2/ s3://cesium-dev-sandcastle-website/ --cache-control "public, max-age=1800" --delete
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the vite build is bundling a copy of CesiumJS already. Is there a reason we are doing that and then pulling another copy of the latest version from github?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simply because it was in the prod deploy workflow I copied from. Confirmed it's not needed and removed 👍

@jjspace jjspace force-pushed the sandcastle-dev-deployment branch from 1ae5b15 to 7f476c8 Compare June 27, 2025 22:55
@jjspace
Copy link
Contributor Author

jjspace commented Jun 27, 2025

@ggetz I think this should be good to go now. In testing the last change I realized we had no way to tell what "version" of the code was running or when the server cache was updated. I added a very quick commit hash to the top right as a short term solution. We can figure out a better way to display the version later, todo added to the main list.

@ggetz
Copy link
Contributor

ggetz commented Jul 7, 2025

Sounds good, thanks @jjspace!

@ggetz ggetz merged commit 852f7ef into sandcastle-v2 Jul 7, 2025
9 checks passed
@ggetz ggetz deleted the sandcastle-dev-deployment branch July 7, 2025 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants