Revamp the download settings dialog #777
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds option to restart/shutdown pc after installation - Allows limiting the download speed without going to the settings (still needs support for localization)
This reverts commit 635160a.
gablm
added
Enhancement
There was a problem hiding this comment.
Pull Request Overview
Revamps the download settings dialog to offer enhanced post-install actions and integrated download speed limiting.
- Adds new language strings and UI elements to support post-install behaviours (shutdown, restart, hibernate, do nothing) and a customizable timeout.
- Replaces the old StartAfterInstall flag with a new PostInstallBehaviour enum and updates corresponding configuration and UI code.
- Introduces a new DownloadSettings dialog to simplify download speed limiter adjustments.
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Hi3Helper.Core/Lang/en_US.json | Added new UI strings for post-install behaviour options. |
| Hi3Helper.Core/Lang/Locale/LangDialogs.cs | Mapped new language strings in localized dialogs. |
| Hi3Helper.Core/Classes/Shared/Region/LauncherConfig.cs | Added a new config property for post-install shutdown timeout (with a spelling inconsistency). |
| CollapseLauncher/XAMLs/MainApp/ValueConverters.cs | Added a new converter for time formatting. |
| CollapseLauncher/XAMLs/MainApp/Pages/SettingsPage.xaml.cs | Updated settings page to refresh download speed limiter UI. |
| CollapseLauncher/XAMLs/MainApp/Pages/HomePage.xaml.cs | Refactored game start logic to use the new post-install behaviour. |
| CollapseLauncher/XAMLs/MainApp/Pages/HomePage.GameManagement.cs | Integrated post-install procedure logic replacing the old flag. |
| CollapseLauncher/XAMLs/MainApp/Pages/Dialogs/SimpleDialogs.cs | Updated dialog invocation to use the new DownloadSettings control. |
| CollapseLauncher/XAMLs/MainApp/Pages/Dialogs/DownloadSettings.xaml.cs & .xaml | New dialog UI and code-behind for configuring download speed and post-install timeout. |
| CollapseLauncher/Classes/Interfaces/IGameInstallManager.cs | Removed the old StartAfterInstall property in favour of PostInstallBehaviour. |
| CollapseLauncher/Classes/Interfaces/Class/Enums.cs | Introduced the new PostInstallBehaviour enum. |
| CollapseLauncher/Classes/InstallManagement/Base/InstallManagerBase.cs | Extended the install manager base class to support PostInstallBehaviour while retaining legacy StartAfterInstall. |
Comments suppressed due to low confidence (1)
CollapseLauncher/Classes/InstallManagement/Base/InstallManagerBase.cs:161
- Both 'StartAfterInstall' and the new 'PostInstallBehaviour' properties exist. If 'StartAfterInstall' is no longer used, consider deprecating or removing it to prevent confusion.
public virtual bool StartAfterInstall { get; set; }
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
CollapseLauncher/XAMLs/MainApp/Pages/Dialogs/DownloadSettings.xaml.cs
Dismissed
Show dismissed
Hide dismissed
CollapseLauncher/XAMLs/MainApp/Pages/HomePage.GameManagement.cs
Dismissed
Show dismissed
Hide dismissed
CollapseLauncher/XAMLs/MainApp/Pages/HomePage.GameManagement.cs
Dismissed
Show dismissed
Hide dismissed
|
CollapseLauncher/XAMLs/MainApp/Pages/Dialogs/DownloadSettings.xaml.cs
Dismissed
Show dismissed
Hide dismissed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main Goal
Adds new options to what behaviour the launcher should have after a successful install or update: shutdown, restart or hibernate. The timeout between the completion of the install and the shutdown/restart can be customized.
(closes #628)
Allows limiting download speed without going to the settings page.
PR Status :
Templates
Changelog Prefixes