feat: add option to hide the channel link #7514
Conversation
Adds an option to hide the channel link from a video closes FreeTubeApp#3193
This prevents the sharing actions from being moved to where the profile would be, once the profile is hidden via the parental controls.
github-actions
bot
added
the
PR: waiting for review
There was a problem hiding this comment.
Combined with all our other parental and distraction free settings i think this is a pretty good addition
The only thing im not sure about is the label, Hide Channel Link. Im not sure if its clear enough for a person that is reading this the first time on what this actually does
|
Also |
|
@PikachuEXE Yeah the name is definitely something which needs to be discussed. I previously also had "Hide Channel Actions" as the name, but because of the issue I changed it. I am not sure of what to call this. |
|
any ideas for a better name @absidue @ChunkyProgrammer @kommunarr |
efb4f5ff-1298-471a-8973-3d47447115dc
added
PR: changes requested
and removed
PR: waiting for review
|
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
|
Apologies for the delay. Some suggestions i came up with:
I feel the reason that its so hard to come up with a label is that it isnt clear where this is applied and to what elements. For example in our distraction free setting its clear what element is hidden and on what page it is applied |
|
@PikachuEXE I would love to hear your opinion as well! (Since I am not sure of what to use (even with @efb4f5ff-1298-471a-8973-3d47447115dc's suggestions)). |
|
I think |
|
We already have a setting to hide the subscribe button so maybe this setting can only hide the channel icon and name so we can name this setting properly? |
|
@PikachuEXE For complexity's sake I would love to not do this 😛 |
Head branch was pushed to by a user without write access
This change makes it so only the channel name/icon get hidden, not the subscribe button itself. This makes sense because there is a separate setting to achive this behavior, if needed.
|
This is how it looks now: |
Thats seems highly out of scope of this PR tbh |
|
@efb4f5ff-1298-471a-8973-3d47447115dc Yeah on one side I get what you are saying (and I would love not implementing it :D) but on the other side it is basically a "workaround" to still get to the channel page (which this is trying to prevent). |
FreeTube_mj5LPnO9S8.mp4 |
|
@efb4f5ff-1298-471a-8973-3d47447115dc Thanks for pointing this out! I completely missed that 😂 |
Moves the toggle to the right side (grouping in pairs of two), instead of three on one side and one on the other side
Head branch was pushed to by a user without write access
PikachuEXE
requested review from
absidue,
ChunkyProgrammer and
kommunarr
and removed request for
ChunkyProgrammer and
kommunarr
absidue
added
PR: changes requested
and removed
PR: waiting for review
|
How do I even see linter warnings on GH... |
Hmm weird, we should definitely make it blocking |
firefox_qb41sUOsFY.mp4 |
|
Yeah definitely make them blocking! I did not even notice that they were there (because on my machine I didn't even see them), wasting your time. |
|
@DontBlameMe99 Not sure what you use to do your commits on your computer but the linter runs in a pre-commit hook so you should see them in the output (they are definitely visible in the command line, but I'm not sure how GUI editors handle them). You should also see the yellow squiggles in your editor if you have Vue and ESLint integrations set up. |
Head branch was pushed to by a user without write access
DontBlameMe99
dismissed stale reviews from PikachuEXE and efb4f5ff-1298-471a-8973-3d47447115dc
via
228bbeb
|
@absidue Thats weird. I am using nvim with the LSP (which might cause it to use a different formatting, I've noticed this sevaral times). But I am committing/pushing via lazygit/the git CLI, so this should definitely run them - but it doesn't. I'll have to look into this. |
Head branch was pushed to by a user without write access
* development: (27 commits) Translated using Weblate (Turkish) Translated using Weblate (Portuguese (Brazil)) Bump electron from 37.2.4 to 37.2.5 (FreeTubeApp#7777) Bump the eslint group with 2 updates (FreeTubeApp#7778) Bump webpack from 5.100.2 to 5.101.0 (FreeTubeApp#7774) Bump marked from 16.1.1 to 16.1.2 (FreeTubeApp#7776) Translated using Weblate (Swedish) Hide the Electron specific -electron-corner-smoothing CSS rule (FreeTubeApp#7769) Translated using Weblate (Romanian) Translated using Weblate (Romanian) Translated using Weblate (Chinese (Traditional Han script)) Translated using Weblate (German) Translated using Weblate (Italian) Translated using Weblate (Chinese (Simplified Han script)) Translated using Weblate (Estonian) Translated using Weblate (Bulgarian) Translated using Weblate (Hungarian) Translated using Weblate (French) Translated using Weblate (Czech) feat: add option to hide the channel link (FreeTubeApp#7514) ... # Conflicts: # package.json
Pull Request Type
Related issue
closes #3193
Description
This adds a option to the settings (parental controls) which allows the Channel Link to be hidden.
Screenshots
Testing
Open various videos, enable and disable the option
Desktop
Additional context
This was a requested feature (marked with good first issue) and I implemented it.
I am new to contributing actual code to FreeTube. I have previously only contributed themes, so please let me know if anything should be done differently.