-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix some template strings in locale files, add script to find problematic values #7519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
FreeTubeBot
merged 4 commits into
FreeTubeApp:development
from
ChunkyProgrammer:fix-some-template-strings
Jun 27, 2025
Merged
Fix some template strings in locale files, add script to find problematic values #7519
FreeTubeBot
merged 4 commits into
FreeTubeApp:development
from
ChunkyProgrammer:fix-some-template-strings
Jun 27, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PikachuEXE
previously approved these changes
Jun 6, 2025
absidue
reviewed
Jun 6, 2025
2f68245
to
171be96
Compare
efb4f5ff-1298-471a-8973-3d47447115dc
previously approved these changes
Jun 17, 2025
absidue
previously approved these changes
Jun 17, 2025
Wondering if duplicate variables can/should be ignored |
We should only need to validate if the key is in the string, not how many times the key is in the string
d047f06
absidue
approved these changes
Jun 26, 2025
PikachuEXE
approved these changes
Jun 26, 2025
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
I ended up updating some code that I wrote for Invidious to find locales that use incorrect template strings/are missing template strings. iv-org/invidious#1951 (comment)
This should make finding issues with other locales a lot easier
Ideally we would upstream some of this functionality into vue-i18n-eslint
Screenshots
Testing
yarn run checkforbadtemplates
should create alocale-errors.json
file at the root of the project as well as log the errors to the console. I didn't fix every issue as some of them aren't that straightforward without knowing the language that is being translated.Desktop