-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Update single user playlist view to remove videos immediately on exit #7544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update single user playlist view to remove videos immediately on exit #7544
Conversation
efb4f5ff-1298-471a-8973-3d47447115dc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the total watch time gets updated immediately but video count not. Best to also update the video count.
VirtualBoxVM_DgADC0nR1Y.mp4
It says "Video" has been removed but i removed multiple.
VirtualBoxVM_HvbRafxbBw.mp4
Video count doesnt get updated on playlist page
VirtualBoxVM_BBqti65nYx.mp4
Addressed
Not related to the issue. Maybe someone can create a followup PR? :)
More unrelated to this issue than the above one. That's asking for instant update of local playlist attributes and I dunno if performance would be worse (and I don't see a need for instant update |
|
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
…FreeTubeApp#7544) * * Update single user playlist view to remove videos immediately on exit * $ Update `removeVideos` usage to remove never used `videoIds` * * Close toast early on view exit * ! Fix unable to remove videos after clicking undo * * Reverse toast message update * * Update video count after remove (before actual remove)
Pull Request Type
Related issue
Undo introduced in #5885
Closes #6934
Description
Undo still useful for removing multiple videos
This PR makes single playlist view remove videos queued for removal after 5s to be removed immediately once
Screenshots
Testing
Ensure videos removed and toast closed on view changed (no longer able to undo)
See test cases from #7099 too
Desktop
Additional context