Skip to content

Conversation

@PikachuEXE
Copy link
Collaborator

@PikachuEXE PikachuEXE commented Jun 10, 2025

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

Undo introduced in #5885
Closes #6934

Description

  1. Error raised if out of playlist view when scheduled task for actual removing videos from playlist run
  2. IMO annoying to need to stay in the view for 5s when I am just trying to remove 1 finished video and play another one
    Undo still useful for removing multiple videos

Screenshot 2025-06-10 at 09 19 35

This PR makes single playlist view remove videos queued for removal after 5s to be removed immediately once

Screenshots

Testing

  • Create some really long user playlist (easier for testing, e.g. copy one from LTT long playlist
  • Create 2+ windows to ensure change sync (optional, nothing changed on that side
  • Remove 2+ videos, undo, ensure all removal undone (no change on other windows
  • Remove 2+ videos, wait 5s, repeat N times, ensure videos are really removed (can go to another view and back to ensure
  • Remove 2+ videos, exit view immediately (go back to playlists view or about/settings view or start playing one of the items)
    Ensure videos removed and toast closed on view changed (no longer able to undo)
  • Video count shown in playlist info should be updated immediately after remove (before actual remove/undo)

See test cases from #7099 too

Desktop

  • OS:
  • OS Version:
  • FreeTube version:

Additional context

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) June 10, 2025 02:33
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Jun 10, 2025
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the total watch time gets updated immediately but video count not. Best to also update the video count.

VirtualBoxVM_DgADC0nR1Y.mp4

It says "Video" has been removed but i removed multiple.

VirtualBoxVM_HvbRafxbBw.mp4

Video count doesnt get updated on playlist page

VirtualBoxVM_BBqti65nYx.mp4

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added PR: changes requested and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Jun 10, 2025
@PikachuEXE
Copy link
Collaborator Author

So the total watch time gets updated immediately but video count not. Best to also update the video count.

Addressed

It says "Video" has been removed but i removed multiple.

Not related to the issue. Maybe someone can create a followup PR? :)

Video count doesn't get updated on playlist page

More unrelated to this issue than the above one. That's asking for instant update of local playlist attributes and I dunno if performance would be worse (and I don't see a need for instant update

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added PR: waiting for review For PRs that are complete, tested, and ready for review and removed PR: changes requested labels Jun 11, 2025
@github-actions
Copy link
Contributor

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@PikachuEXE
Copy link
Collaborator Author

@ChunkyProgrammer ~

@FreeTubeBot FreeTubeBot merged commit fa3b2d8 into FreeTubeApp:development Jul 3, 2025
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Jul 3, 2025
efb4f5ff-1298-471a-8973-3d47447115dc pushed a commit to efb4f5ff-1298-471a-8973-3d47447115dc/FreeTube that referenced this pull request Jul 12, 2025
…FreeTubeApp#7544)

* * Update single user playlist view to remove videos immediately on exit

* $ Update `removeVideos` usage to remove never used `videoIds`

* * Close toast early on view exit

* ! Fix unable to remove videos after clicking undo

* * Reverse toast message update

* * Update video count after remove (before actual remove)
@PikachuEXE PikachuEXE deleted the feature/playlist-delete-nodelay-onexit branch July 28, 2025 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Removing a video from a playlist then immediately navigating away: video not removed

5 participants