Update jac_lin_coord methods
#501
Open
+19
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@amontoison @tmigot please review the changes made here. |
|
@amontoison @tmigot All test pass except the one breakage/upload one. |
|
@arnavk23 It is a breaking change if we drop the signature with |
tmigot
requested changes
Jul 9, 2025
There was a problem hiding this comment.
Thanks @arnavk23 for the PR.
Can you also adapt jac_lin_op and jac_lin_op! https://github.com/arnavk23/NLPModels.jl/blob/504a3c29574998b892d7f598283db466a86e391e/src/nlp/api.jl#L737
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The linear Jacobian part is independent of
x, so passing it became unnecessary.jac_lin_coord(nlp, x)→jac_lin_coord(nlp)jac_lin_coord!(nlp, x, vals)→jac_lin_coord!(nlp, vals)Closes #404