Skip to content

Fixes #38436 - Override assign_taxonomy to check registered hosts before assigning to a new organization #11396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lfu
Copy link
Member

@lfu lfu commented May 20, 2025

What are the changes introduced in this pull request?

Based on theforeman/foreman#10538.

Considerations taken when implementing this change?

What are the testing steps for this pull request?

Summary by Sourcery

Prevent reassignment of registered hosts to a different organization by overriding the assign_taxonomy bulk action to validate hosts before proceeding.

Bug Fixes:

  • Check for hosts with active subscriptions and block organization assignment until they are unregistered.

Enhancements:

  • Override assign_taxonomy to render a custom error when attempting to assign a registered host to a new organization.

Copy link

sourcery-ai bot commented May 20, 2025

Reviewer's Guide

Overrides the assign_taxonomy bulk action to pre-check for hosts with active subscriptions in a different organization and block reassignment until they are unregistered, then delegates to the original implementation.

File-Level Changes

Change Details Files
Introduce assign_taxonomy override with subscription validation before organization assignment
  • Check for presence of target_organization_id parameter
  • Query @hosts for any host with a subscription_facet not already in the target organization
  • Render a bad_request custom_error when a registered host is found
  • Fall back to calling super if no blocking hosts exist
app/controllers/katello/concerns/api/v2/hosts_bulk_actions_controller_extensions.rb

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lfu - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant