Skip to content

Refs #38496 - Add preset bookmarks for registered hosts #11418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jeremylenz
Copy link
Member

@jeremylenz jeremylenz commented Jun 13, 2025

What are the changes introduced in this pull request?

image

A lot of people don't know the scoped_search syntax for if something is null or not null. also I recently discovered we can add pre-set bookmarks via seeds, so I can see the utility of adding some for

set? subscription_uuid

which defines if a host is registered, and

null? subscription_uuid

for unregistered hosts.

Considerations taken when implementing this change?

What are the testing steps for this pull request?

Summary by Sourcery

Seed two new preset bookmarks to allow quick filtering of registered and unregistered hosts based on subscription UUID presence

New Features:

  • Add default 'Registered hosts' bookmark to filter hosts with a subscription UUID
  • Add default 'Unregistered hosts' bookmark to filter hosts without a subscription UUID

Copy link

sourcery-ai bot commented Jun 13, 2025

Reviewer's Guide

Adds two new seed bookmarks for hosts, enabling quick filters for registered and unregistered hosts by leveraging scoped_search checks on subscription_uuid.

File-Level Changes

Change Details Files
Introduction of preset bookmark entries for host registration status
  • Add “Registered hosts” bookmark with query ‘set? subscription_uuid’
  • Add “Unregistered hosts” bookmark with query ‘null? subscription_uuid’
db/seeds.d/108-subcription-bookmarks.rb

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jeremylenz - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@jeremylenz jeremylenz force-pushed the 38496-registered-hosts-bookmarks branch from 1b6fea9 to 9267ef1 Compare June 16, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant