NRE - Volo.Abp.AspNetCore.Uow.AspNetCoreUnitOfWorkTransactionBehaviourProvider.get_IsTransactional()

[FloppyChips]

Is there an existing issue for this?

• I have searched the existing issues

Description

ABP 8.1.1

Seeing this exception with multithreaded application where each thread creates it own UOW with the IUnitOfWorkManager:

System.NullReferenceException: Object reference not set to an instance of an object.
at Microsoft.AspNetCore.Http.DefaultHttpRequest.get_Path()
at Volo.Abp.AspNetCore.Uow.AspNetCoreUnitOfWorkTransactionBehaviourProvider.get_IsTransactional()
at Volo.Abp.Uow.UnitOfWorkInterceptor.CreateOptions(IServiceProvider serviceProvider, IAbpMethodInvocation invocation, UnitOfWorkAttribute unitOfWorkAttribute)
at Volo.Abp.Uow.UnitOfWorkInterceptor.InterceptAsync(IAbpMethodInvocation invocation)
at Volo.Abp.Castle.DynamicProxy.CastleAsyncAbpInterceptorAdapter1.InterceptAsync[TResult](IInvocation invocation, IInvocationProceedInfo proceedInfo, Func3 proceed)

Seems to be looking at the current request path on HttpContext which I understand is not thread safe.

Regards Stuart

Reproduction Steps

No response

Expected behavior

No response

Actual behavior

No response

Regression?

No response

Known Workarounds

No response

Version

8.1.1

User Interface

Common (Default)

Database Provider

EF Core (Default)

Tiered or separate authentication server

Tiered

Operation System

Windows (Default)

Other information

No response

[maliming]

hi

Reproduction Steps?

[FloppyChips]

I haven't had the opportunity to isolate to a small test case, however I have concluded that ABP is not suitable for multithreading in the situation where a HttpContext is defined, such as in an application service. Both the UOW code and Serilog extensions access the context to determine the Http method and other properties and this isn't thread safe. Perhaps something for your documentation. I don't know how it fairs under a console app where there is no HttpContext defined.

[maliming]

You can try to override the AspNetCoreUnitOfWorkTransactionBehaviourProvider class.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.