-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Revisions for the modular development tutorial #23128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revisions for the modular development tutorial #23128
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Modular CRM tutorial to rename and refactor references from "Products" to "Catalog" for consistency and refreshes module names and sample code. Key changes:
- Renamed all mentions of the Products module to Catalog across tutorial parts and navigation.
- Updated namespaces and package references in code examples to reflect the Catalog module.
- Added null-forgiving initializers to DTO properties and adjusted download link to new sample path.
Reviewed Changes
Copilot reviewed 10 out of 41 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
docs/en/tutorials/modular-crm/index.md | Updated tutorial nav and download link to reflect Catalog naming. |
docs/en/tutorials/modular-crm/part-01.md | Added initial modularity step details and Catalog module setup. |
docs/en/tutorials/modular-crm/part-02.md | Renamed Products to Catalog in installation instructions. |
docs/en/tutorials/modular-crm/part-03.md | Renamed Products module to Catalog module throughout. |
docs/en/tutorials/modular-crm/part-04.md | Adjusted summary and module creation text for consistency. |
docs/en/tutorials/modular-crm/part-05.md | Changed service and DTO namespaces to Ordering.Contracts.Enums. |
docs/en/tutorials/modular-crm/part-06.md | Updated integration service references from Products to Catalog. |
docs/en/tutorials/modular-crm/part-07.md | Switched event subscriber code examples from Products to Catalog. |
docs/en/tutorials/modular-crm/part-08.md | Refactored reporting service examples to Catalog and added DTO defaults. |
docs/en/docs-nav.json | Updated docs navigation entries for Catalog module parts. |
Comments suppressed due to low confidence (3)
docs/en/tutorials/modular-crm/part-08.md:61
- The interface code snippet defines
Task<List<OrderReportDto>>
but is missingusing System.Threading.Tasks;
andusing System.Collections.Generic;
. Add these directives so the interface compiles.
using ModularCrm.Orders;
docs/en/tutorials/modular-crm/part-08.md:106
- This import should reference the actual integration service contract namespace (e.g.,
ModularCrm.Catalog.Integration
orModularCrm.Catalog.Contracts.Services
) rather than the root module namespace.
using ModularCrm.Catalog;
docs/en/tutorials/modular-crm/part-08.md:106
- The service example code uses
Task
andList
, but the snippet has removedusing System;
,using System.Collections.Generic;
,using System.Linq;
, andusing System.Threading.Tasks;
. Re-add those imports above to avoid compile errors.
using ModularCrm.Catalog;
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 22.2%, saving 868.57 KB.
2875 images did not require optimisation. |
…github.com/abpframework/abp into EngincanV/update-modular-monolith-tutorial
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 31%, saving 3.39 KB.
2920 images did not require optimisation. |
…github.com/abpframework/abp into EngincanV/update-modular-monolith-tutorial
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 37.7%, saving 22.10 KB.
2919 images did not require optimisation. |
…github.com/abpframework/abp into EngincanV/update-modular-monolith-tutorial
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 24.9%, saving 11.62 KB.
2920 images did not require optimisation. |
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 32.9%, saving 16.61 KB.
2917 images did not require optimisation. |
…github.com/abpframework/abp into EngincanV/update-modular-monolith-tutorial
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 33.5%, saving 69.53 KB.
2916 images did not require optimisation. |
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 32.3%, saving 9.43 KB.
2920 images did not require optimisation. |
…github.com/abpframework/abp into EngincanV/update-modular-monolith-tutorial
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 28.8%, saving 28.52 KB.
2918 images did not require optimisation. |
…github.com/abpframework/abp into EngincanV/update-modular-monolith-tutorial
Resolves #23072
The sample application is also updated: abpframework/abp-samples#295