-
Notifications
You must be signed in to change notification settings - Fork 396
Add Thermal Resistance (KelvinPerWatt and DegreesCelsiusPerWatt) #1560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Thermal Resistance (KelvinPerWatt and DegreesCelsiusPerWatt) #1560
Conversation
wanted to follow up to see if this PR could be merged into pre-release? or curious what the blocker for it is?🙏 @lipchev @angularsen |
hi @angularsen @lipchev just wanted to check if it's still possible to get this merged? Or if there is something I need to do on my end? thank you :) |
…ce-kelvinperwatt # Conflicts: # UnitsNet/GeneratedCode/Quantity.g.cs
@andrewmeservy Sorry for taking so long, vacations and hectic work life running up to it. LGTM, merging. |
"SquareCentimeterKelvinPerWatt": 3, | ||
"SquareMeterDegreeCelsiusPerWatt": 4, | ||
"SquareMeterKelvinPerKilowatt": 5, | ||
"SquareMeterKelvinPerWatt": 6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be safe to remove, they no longer make sense after the previous rename. Starting the new number sequence higher, to be safe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
true, I didn't notice, thank you!
no worries at all about the delay, thank you so much for actively maintaining this project, I'm sure it can be a lot of work!! cheers |
Related discussion: #1558