Skip to content

Add Thermal Resistance (KelvinPerWatt and DegreesCelsiusPerWatt) #1560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

andrewmeservy
Copy link
Contributor

  • Add Thermal Resistance with KelvinPerWatt and DegreesCelsiusPerWatt

Related discussion: #1558

@andrewmeservy
Copy link
Contributor Author

wanted to follow up to see if this PR could be merged into pre-release? or curious what the blocker for it is?🙏 @lipchev @angularsen

@andrewmeservy
Copy link
Contributor Author

hi @angularsen @lipchev just wanted to check if it's still possible to get this merged? Or if there is something I need to do on my end? thank you :)

…ce-kelvinperwatt

# Conflicts:
#	UnitsNet/GeneratedCode/Quantity.g.cs
@angularsen
Copy link
Owner

@andrewmeservy Sorry for taking so long, vacations and hectic work life running up to it.
I fixed merge conflicts and removed the old lingering enum values that no longer make sense after the rename.

LGTM, merging.

"SquareCentimeterKelvinPerWatt": 3,
"SquareMeterDegreeCelsiusPerWatt": 4,
"SquareMeterKelvinPerKilowatt": 5,
"SquareMeterKelvinPerWatt": 6
Copy link
Owner

@angularsen angularsen Jul 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be safe to remove, they no longer make sense after the previous rename. Starting the new number sequence higher, to be safe.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true, I didn't notice, thank you!

@angularsen angularsen merged commit 426ea00 into angularsen:master Jul 25, 2025
1 check was pending
@angularsen
Copy link
Owner

@andrewmeservy
Copy link
Contributor Author

@andrewmeservy Sorry for taking so long, vacations and hectic work life running up to it. I fixed merge conflicts and removed the old lingering enum values that no longer make sense after the rename.

LGTM, merging.

no worries at all about the delay, thank you so much for actively maintaining this project, I'm sure it can be a lot of work!! cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants