Fix for dynamic scaling toggle for instance

[sudo87]

Description

This PR fixes #10835 issue.

1. New capability param is included in listCapabilities response:

"dynamicscalingenabled": true

2. Using above to toggle Dynamic scaling for Deploy, Edit instance

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 16.57%. Comparing base (8e4fe1c) to head (e579369).

Files with missing lines	Patch %	Lines
.../cloudstack/api/response/CapabilitiesResponse.java	0.00%	3 Missing ⚠️
...k/api/command/user/config/ListCapabilitiesCmd.java	0.00%	1 Missing ⚠️
...in/java/com/cloud/server/ManagementServerImpl.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               main   #11086   +/-   ##
=========================================
  Coverage     16.57%   16.57%           
+ Complexity    13988    13987    -1     
=========================================
  Files          5745     5745           
  Lines        510847   510844    -3     
  Branches      62140    62137    -3     
=========================================
  Hits          84696    84696           
+ Misses       416677   416674    -3     
  Partials       9474     9474           

Flag	Coverage Δ
uitests	3.91% <ø> (+<0.01%)	⬆️
unittests	17.47% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[sudo87]

@blueorangutan package

[blueorangutan]

@sudo87 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13918

[shwstppr]

Code LGTM. Minor nits

[DaanHoogland]

clgtm

[DaanHoogland]

@sudo87 , can you add some testing advice?

[sudo87]

@sudo87 , can you add some testing advice?

Apologies, missed to add dev testing scenario.

I have followed the steps mentioned in the issue by @shwstppr, to confirm if Dynamic scaling option gets enabled.

1. Enable config - enable.dynamic.scale.vm if not true already
2. Create a compute offering with Dynamic Scaling enabled if not present already
3. Register a template with Dynamic Scaling enabled if not present already
4. Log in into UI as a normal user and go to deploy VM wizard
5. Dynamic scaling option under Advanced mode gets Enabled

#10835 (comment)

[github-actions]

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.