[Vmware to KVM Migration] Fix issue with vCenter Standalone hosts for VM listing

[nvazquez]

Description

This PR fixes the listing of VMware VMs for Migration to KVM on vCenter datacenters that have standalone hosts (don't belong to any cluster)

Example setup with standalone hosts:

Listing retrieved successfully, setting cluster field empty on the listing table:

Fixes: #11090

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Set standalone hosts on the datacenter, having VMs on them
List VMs for Migration on CloudStack pointing to the vCenter

How did you try to break this feature and the system with this change?

[nvazquez]

@blueorangutan package

[blueorangutan]

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 15.18%. Comparing base (cbd2b5a) to head (3af1702).
Report is 2 commits behind head on 4.19.

Files with missing lines	Patch %	Lines
...in/java/com/cloud/hypervisor/vmware/mo/BaseMO.java	0.00%	12 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               4.19   #11091   +/-   ##
=========================================
  Coverage     15.17%   15.18%           
- Complexity    11363    11365    +2     
=========================================
  Files          5416     5416           
  Lines        475911   475919    +8     
  Branches      58096    58095    -1     
=========================================
+ Hits          72241    72251   +10     
+ Misses       395584   395582    -2     
  Partials       8086     8086           

Flag	Coverage Δ
uitests	4.28% <ø> (ø)
unittests	15.90% <0.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13921

[DaanHoogland]

@blueorangutan test ol8 vmware-80u3

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-80u3) has been kicked to run smoke tests

[DaanHoogland]

Suggested change

	String msg = String.format("Standalone host %s found, setting empty cluster field", hostName);
	s_logger.debug(msg);
	String msg = String.format(“Host %s not found, assuming standalone host, setting cluster name as empty", hostName);
	s_logger.info(msg);

[nvazquez]

Hi @DaanHoogland the host is found, but not its cluster. Let me rephrase it a bit

[weizhouapache]

code lgtm

[sureshanaparti]

code lgtm

[nvazquez]

@blueorangutan package

[blueorangutan]

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[DaanHoogland]

clgtm

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14067