Skip to content

merge acs-api-commands project into tools #11098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 51 commits into
base: main
Choose a base branch
from

Conversation

pdion891
Copy link
Contributor

@pdion891 pdion891 commented Jun 27, 2025

Description

As suggested in the mailing list, here is the merge of acs-api-commands/
which is use to create CloudStack Release Notes to extract new or update api's.

Project renamed into folder tools/apidoc-versions-diff

once this PR merge, the project acs-api-commands/ will be mark as archived/deprecated with a link to this folder.

  • Release note updated.
  • old license file removed.

Perform using git subtree which kept previous commit histories;

git subtree add -P tools/apidoc-versions-diff git@github.com:pdion891/acs-api-commands.git HEAD

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

How Has This Been Tested?

No.

How did you try to break this feature and the system with this change?

Did not.

Copy link

codecov bot commented Jun 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.57%. Comparing base (16c60c7) to head (16d6529).

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #11098      +/-   ##
============================================
- Coverage     16.57%   16.57%   -0.01%     
  Complexity    13968    13968              
============================================
  Files          5743     5743              
  Lines        510494   510494              
  Branches      62075    62075              
============================================
- Hits          84617    84616       -1     
  Misses       416415   416415              
- Partials       9462     9463       +1     
Flag Coverage Δ
uitests 3.90% <ø> (ø)
unittests 17.47% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sureshanaparti sureshanaparti requested a review from Copilot July 4, 2025 12:34
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR merges the existing acs-api-commands project into the tools/apidoc-versions-diff directory (preserving its history), removes the old license file, and updates the release notes accordingly.

  • Added a subtree for tools/apidoc-versions-diff with diff.txt and diff.json for versions 4.19→4.20 (and earlier).
  • Removed the old license file and updated release notes.
  • No functional changes to existing code; purely a build/CI and tooling import.

Reviewed Changes

Copilot reviewed 31 out of 52 changed files in this pull request and generated 1 comment.

File Description
tools/apidoc-versions-diff/diff-419-420/diff.txt Imported raw API commands diff for CloudStack 4.19→4.20
tools/apidoc-versions-diff/diff-419-420/diff.json Imported structured JSON diff for CloudStack 4.19→4.20
Comments suppressed due to low confidence (2)

tools/apidoc-versions-diff/diff-419-420/diff.txt:17

  • [nitpick] Command descriptions should start with an uppercase verb in third-person singular (e.g., Deletes a backup repository).
    deleteBackupRepository (delete a backup repository)

tools/apidoc-versions-diff/diff-419-420/diff.txt:29

  • The command name uses Nsx rather than NSX; consider renaming to deleteNSXController to reflect the acronym consistently.
    deleteNsxController (delete NSX Controller to CloudStack)


purgeExpungedResources (Purge expunged resources)

deleteNsxController (delete NSX Controller to CloudStack)
Copy link
Preview

Copilot AI Jul 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description reads 'to CloudStack' but should say 'from CloudStack' to accurately reflect removal.

Suggested change
deleteNsxController (delete NSX Controller to CloudStack)
deleteNsxController (delete NSX Controller from CloudStack)

Copilot uses AI. Check for mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants