-
Notifications
You must be signed in to change notification settings - Fork 1.2k
merge acs-api-commands project into tools #11098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
added 4.9 and updated readme
Updated README and added 4.10 commands
Update to 4.14 Thanks @andrijapanicsb !
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
4.15 changes
4.16.0 changes
4.17.0 Release diff
4.18 api docs
Add 4.19 and 4.20 api commands
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11098 +/- ##
============================================
- Coverage 16.57% 16.57% -0.01%
Complexity 13968 13968
============================================
Files 5743 5743
Lines 510494 510494
Branches 62075 62075
============================================
- Hits 84617 84616 -1
Misses 416415 416415
- Partials 9462 9463 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR merges the existing acs-api-commands project into the tools/apidoc-versions-diff directory (preserving its history), removes the old license file, and updates the release notes accordingly.
- Added a subtree for tools/apidoc-versions-diff with diff.txt and diff.json for versions 4.19→4.20 (and earlier).
- Removed the old license file and updated release notes.
- No functional changes to existing code; purely a build/CI and tooling import.
Reviewed Changes
Copilot reviewed 31 out of 52 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
tools/apidoc-versions-diff/diff-419-420/diff.txt | Imported raw API commands diff for CloudStack 4.19→4.20 |
tools/apidoc-versions-diff/diff-419-420/diff.json | Imported structured JSON diff for CloudStack 4.19→4.20 |
Comments suppressed due to low confidence (2)
tools/apidoc-versions-diff/diff-419-420/diff.txt:17
- [nitpick] Command descriptions should start with an uppercase verb in third-person singular (e.g.,
Deletes a backup repository
).
deleteBackupRepository (delete a backup repository)
tools/apidoc-versions-diff/diff-419-420/diff.txt:29
- The command name uses
Nsx
rather thanNSX
; consider renaming todeleteNSXController
to reflect the acronym consistently.
deleteNsxController (delete NSX Controller to CloudStack)
|
||
purgeExpungedResources (Purge expunged resources) | ||
|
||
deleteNsxController (delete NSX Controller to CloudStack) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The description reads 'to CloudStack' but should say 'from CloudStack' to accurately reflect removal.
deleteNsxController (delete NSX Controller to CloudStack) | |
deleteNsxController (delete NSX Controller from CloudStack) |
Copilot uses AI. Check for mistakes.
Description
As suggested in the mailing list, here is the merge of acs-api-commands/
which is use to create CloudStack Release Notes to extract new or update api's.
Project renamed into folder
tools/apidoc-versions-diff
once this PR merge, the project acs-api-commands/ will be mark as archived/deprecated with a link to this folder.
Perform using git subtree which kept previous commit histories;
Types of changes
Feature/Enhancement Scale
Bug Severity
How Has This Been Tested?
No.
How did you try to break this feature and the system with this change?
Did not.