fix(buildPath): revert checking buildPath #21040
Merged
+0
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! The pull request is marked to be |
|
The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-21040@1fe657d |
100pah
approved these changes
Jun 18, 2025
|
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
Ovilia
added
the
PR: supplementary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Revert checking
buildPathfrom d2c05a7.Fixed issues
Details
Before: What was the problem?
I forgot why I added this code, probably to fix the cause where
pathis aPathinstance rather than a plain object, in the case of custom stage chart. I checked it's not depended by the stage chart and visual tests don't fail without this change so I decide to revert it.After: How does it behave after the fixing?
Nothing is expected to be different.
Document Info
One of the following should be checked.
Misc
ZRender Changes
Related test cases or examples to use the new APIs
N.A.
Others
Merging options
Other information