Benchmark Script #173
Benchmark Script #173
Conversation
|
I can confirm through my fork that pointing to this branch as the 'main' branch yields correct behaviour. The benchmarks run and the comment is posted (this part is already merged). |
Pull Request Test Coverage Report for Build 15045083592Details
💛 - Coveralls |
benchmarks/CMakeLists.txt
Outdated
| cmake_policy(SET CMP0092 NEW) | ||
| project(xad_benchmarks LANGUAGES CXX) | ||
|
|
||
| set(CMAKE_CXX_STANDARD 17) # TEMPORARY |
There was a problem hiding this comment.
Why temporary? Is this needed strictly?
There was a problem hiding this comment.
I had this temporarily for my local build. It has been safely removed.
benchmarks/Hessian/hessian.hpp
Outdated
| #ifdef _WIN32 | ||
| #define _USE_MATH_DEFINES | ||
| #endif |
There was a problem hiding this comment.
Can we add that to the compile flags in windows for the benchmarks only? target_compile_options
scripts/benchmark.sh
Outdated
| DIR="/__w/xad/xad/main/build/benchmarks" | ||
| MAIN_DIR="/__w/xad/xad/main/build/benchmarks" |
There was a problem hiding this comment.
Any chance to get these dirs from CI environment variables?
| echo "" | ||
| FULL_DATE=$(jq -r '.[0].context.date' "$DIR/benchmark.json") | ||
| RUN_DATE=$(echo "$FULL_DATE" | cut -d'T' -f1) | ||
| echo "**Run Date:** $RUN_DATE" |
There was a problem hiding this comment.
Please also add some info on platform, CPU, compiler, and etc. Important to reproduce results.
There was a problem hiding this comment.
I'll do this in the other PR.
There was a problem hiding this comment.
This is done in the other PR, but this one'll need to be merged before I can check it works as intended.
Description
Adds the benchmarking script and files. Sister PR to #168.