Skip to content

test(client-cloudwatch): add query compatibility test for error shape ambiguity #7163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 30, 2025
Merged

test(client-cloudwatch): add query compatibility test for error shape ambiguity #7163

merged 3 commits into from
Jun 30, 2025

Conversation

smilkuri
Copy link
Contributor

Issue

Internal JS-6017

Description

Implements smoke test equivalent for AmbiguousErrorResolution to ensure ResourceNotFound error code consistently maps to expected exception type,

Testing

Locally

 RUN  v2.1.9 /local/home/smilkuri/aws-sdk-js-v3/clients/client-cloudwatch

 ✓ test/e2e/query-compatibility.e2e.spec.ts (1) 541ms
   ✓ CloudWatch Query Compatibility E2E (1) 541ms
     ✓ AmbiguousErrorResolution 535ms

 Test Files  1 passed (1)
      Tests  1 passed (1)
   Start at  02:21:52
   Duration  1.06s (transform 141ms, setup 0ms, collect 246ms, tests 541ms, environment 0ms, prepare 90ms)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@smilkuri smilkuri requested a review from a team as a code owner June 30, 2025 02:22
siddsriv
siddsriv reviewed Jun 30, 2025
View reviewed changes
clients/client-cloudwatch/package.json Outdated
@@ -11,7 +11,10 @@
"build:types:downlevel": "downlevel-dts dist-types dist-types/ts3.4",
"clean": "rimraf ./dist-* && rimraf *.tsbuildinfo",
"extract:docs": "api-extractor run --local",
"generate:client": "node ../../scripts/generate-clients/single-service --solo cloudwatch"
"generate:client": "node ../../scripts/generate-clients/single-service --solo cloudwatch",
"test": "yarn g:vitest run -c vitest.config.e2e.ts",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should not run e2e test, will create problems in CI most probably

@smilkuri smilkuri merged commit 963418d into main Jun 30, 2025
8 checks passed
@trivikr trivikr deleted the queryCompat branch June 30, 2025 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siddsriv siddsriv siddsriv left review comments

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smilkuri @trivikr @siddsriv