Skip to content

refact: pkg/database decisions filter, queries #3635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 23, 2025
Merged

refact: pkg/database decisions filter, queries #3635

merged 5 commits into from
Jul 23, 2025

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented May 16, 2025

No description provided.

@mmetc mmetc added this to the Next release milestone May 16, 2025
Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

codecov bot commented May 16, 2025

Codecov Report

Attention: Patch coverage is 66.83938% with 64 lines in your changes missing coverage. Please review.

Project coverage is 60.65%. Comparing base (d64ee2a) to head (e39ad43).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/database/decisionfilter.go 63.63% 56 Missing and 4 partials ⚠️
pkg/database/decisions.go 83.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3635      +/-   ##
==========================================
- Coverage   60.70%   60.65%   -0.06%     
==========================================
  Files         374      375       +1     
  Lines       41322    41328       +6     
==========================================
- Hits        25086    25067      -19     
- Misses      14166    14186      +20     
- Partials     2070     2075       +5     
Flag Coverage Δ
bats 44.74% <64.76%> (-0.03%) ⬇️
unit-linux 34.27% <33.16%> (-0.03%) ⬇️
unit-windows 24.30% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mmetc mmetc force-pushed the db-decisions branch 2 times, most recently from 511b368 to 6910825 Compare June 3, 2025 13:08
@mmetc mmetc requested a review from sabban June 27, 2025 12:40
@mmetc mmetc modified the milestones: Next release, 1.7.0 Jul 4, 2025
@mmetc mmetc requested a review from blotus July 4, 2025 12:36
@blotus blotus linked an issue Jul 8, 2025 that may be closed by this pull request
@mmetc
Copy link
Contributor Author

mmetc commented Jul 8, 2025

@blotus too many conflicts with the ip changes, I'll redo this one for 1.7

@mmetc mmetc removed the request for review from sabban July 8, 2025 14:42
@mmetc mmetc changed the title refact: pkg/database decisions extract, rename refact: pkg/database decisions filter Jul 23, 2025
@mmetc mmetc changed the title refact: pkg/database decisions filter refact: pkg/database decisions filter, queries Jul 23, 2025
@mmetc mmetc merged commit 1df4c24 into master Jul 23, 2025
16 checks passed
@mmetc mmetc deleted the db-decisions branch July 23, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when querying for new decisions
2 participants