Skip to content

refact whitelist/allowlist: net.IP to net/netip #3683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Jun 12, 2025

since address parsing is stricter we need to log or error depending on context, I'm leaving XXX

@mmetc mmetc added this to the Next release milestone Jun 12, 2025
Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

codecov bot commented Jun 12, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 6 lines in your changes missing coverage. Please review.

Project coverage is 60.66%. Comparing base (ab7ca05) to head (82cf1bf).

Files with missing lines Patch % Lines
pkg/apiserver/apic.go 50.00% 3 Missing and 1 partial ⚠️
pkg/database/allowlists.go 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3683      +/-   ##
==========================================
- Coverage   60.68%   60.66%   -0.02%     
==========================================
  Files         373      373              
  Lines       41164    41171       +7     
==========================================
- Hits        24980    24977       -3     
- Misses      14131    14138       +7     
- Partials     2053     2056       +3     
Flag Coverage Δ
bats 44.71% <41.66%> (+0.06%) ⬆️
unit-linux 34.28% <77.77%> (-0.01%) ⬇️
unit-windows 24.28% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mmetc mmetc force-pushed the allowlist-netip branch 2 times, most recently from b51c153 to bcf6d4b Compare June 20, 2025 09:07
@mmetc mmetc force-pushed the allowlist-netip branch from bcf6d4b to e81493b Compare June 30, 2025 07:29
@mmetc mmetc force-pushed the allowlist-netip branch from e81493b to 82cf1bf Compare July 4, 2025 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant