Skip to content

enhance: Add allowlist check #3684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

LaurenceJJones
Copy link
Contributor

Allowlist check command takes a value and checks if the value is allowlisted, the value can be a range or IP address, we do not explicitly check the type as the LAPI should be able to handle malformed data.

The command uses exit codes to indicate if the value is allowlisted in case the user wants to place in CI/CD and doesnt want to grep for the output.

Copy link

@LaurenceJJones: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@LaurenceJJones: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@LaurenceJJones
Copy link
Contributor Author

/kind enhancement
/area cscli

Copy link

codecov bot commented Jun 13, 2025

Codecov Report

Attention: Patch coverage is 27.77778% with 39 lines in your changes missing coverage. Please review.

Project coverage is 60.61%. Comparing base (3775a72) to head (0249e5c).

Files with missing lines Patch % Lines
cmd/crowdsec-cli/cliallowlists/allowlists.go 27.77% 38 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3684      +/-   ##
==========================================
- Coverage   60.64%   60.61%   -0.03%     
==========================================
  Files         372      372              
  Lines       41063    41117      +54     
==========================================
+ Hits        24901    24924      +23     
- Misses      14105    14137      +32     
+ Partials     2057     2056       -1     
Flag Coverage Δ
bats 44.30% <27.77%> (-0.09%) ⬇️
unit-linux 34.26% <0.00%> (-0.04%) ⬇️
unit-windows 24.23% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cscli kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant