Skip to content

Fix aarch64 docker build #551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

polyfloyd
Copy link
Contributor

@polyfloyd polyfloyd commented May 25, 2025

According to the CI, the docker build for 64 bit ARM is failing. Judging from the logs it seems to be missing the C++ compiler for this target. This is an attempted fix...

I have also merged the apt commands in the Dockerfile and removed the part that removed packages again as that does actually not save space in the Docker image being built.

Summary by Sourcery

Fix the aarch64 Docker build by installing the missing C++ compiler and streamlining package installation and cleanup

Bug Fixes:

  • Install g++ to support 64-bit ARM builds

Build:

  • Merge multiple apt installs into a single RUN and switch from apt-get to apt
  • Remove the separate package purge step and clean apt caches inline to reduce layers

Copy link

sourcery-ai bot commented May 25, 2025

Reviewer's Guide

The Dockerfile was refactored to fix the aarch64 build by switching to apt commands, adding the missing C++ compiler, and consolidating cleanup steps to streamline image size.

File-Level Changes

Change Details Files
Refactored package installation to use apt and merge update steps
  • Replaced apt-get update/install with apt update/install
  • Merged multiple update/install runs into a single RUN command
  • Preserved --no-install-recommends across installs
Dockerfile
Added missing C++ compiler for aarch64 target
  • Included g++ in the build package list
Dockerfile
Optimized cleanup by removing separate removal step and cleaning caches inline
  • Removed standalone apt-get remove --purge block
  • Added rm -rf of /var/cache/apt and /var/lib/apt/lists/* in the installation RUN
  • Dropped redundant cleanup at end of Dockerfile
Dockerfile

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant