Skip to content

refactor(stylelint): remove depreacted rules #3929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

mfranzke
Copy link
Collaborator

Proposed changes

"removing the deprecated rules from your configuration object", source "removing the deprecated rules from your configuration object", source https://github.com/stylelint/stylelint/blob/main/docs/migration-guide/to-15.md#deprecated-stylistic-rules

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

"removing the deprecated rules from your configuration object"
@mfranzke mfranzke added the 🍄🆙improvement New feature or request label Mar 11, 2025
@mfranzke mfranzke self-assigned this Mar 11, 2025
@mfranzke mfranzke requested a review from nmerget as a code owner March 11, 2025 08:20
@mfranzke mfranzke moved this to 👀 In review in UX Engineering Team Backlog Mar 11, 2025
@mfranzke mfranzke removed their assignment Mar 11, 2025
@mfranzke mfranzke enabled auto-merge (squash) March 11, 2025 08:20
Copy link
Contributor

@mfranzke mfranzke changed the title refactor: we could just remove those depreacted rules refactor(stylelint): remove depreacted rules Mar 11, 2025
@mfranzke mfranzke moved this from 👀 In review to 🏗 In development in UX Engineering Team Backlog Mar 17, 2025
@mfranzke mfranzke requested a review from Copilot March 28, 2025 14:37
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • .stylelintrc.json: Language not supported

@nmerget
Copy link
Collaborator

nmerget commented Jun 27, 2025

We cannot remove this because the @stylistic rules comming from this https://github.com/bjankord/stylelint-config-sass-guidelines/blob/main/index.js#L61 config

@nmerget nmerget closed this Jun 27, 2025
auto-merge was automatically disabled June 27, 2025 11:32

Pull request was closed

@github-project-automation github-project-automation bot moved this from 🏗 In development to ✅ Done in UX Engineering Team Backlog Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍄🆙improvement New feature or request
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants