fix(link): eliminate leading and trailing whitespace by inlining Show wrapper #4281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🔭🐙🐈 Test this branch here: https://db-ux-design-system.github.io/core-web/review/fix-remove-leading-trailing-whitspaces-link |
mfranzke
reviewed
May 27, 2025
…spaces-link' into fix-remove-leading-trailing-whitspaces-link
mfranzke
reviewed
Jun 3, 2025
| <Show when={props.text} else={props.children}> | ||
| {props.text} | ||
| </Show> | ||
| {/* prettier-ignore */} |
There was a problem hiding this comment.
Suggested change
| {/* prettier-ignore */} | |
| {/* prettier-ignore-next-line */} |
wouldn't this work ?
mfranzke
reviewed
Jun 3, 2025
|
Unfortunately, we need this PR to be merged to solve this issue. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Remove leading/trailing spaces around the block so that Angular’s generated comments and whitespace no longer produce underlined gaps.
closes #4072
Types of changes