Skip to content

Extend Eligible Nodes for ConfigSelectorMethod to include Saved Query Nodes #11635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

trouze
Copy link
Contributor

@trouze trouze commented May 16, 2025

Resolves #11607

Problem

Today, our ConfigSelectorMethod supports selection from parsed and source nodes only.

As an example, you can do this dbt ls -s config.meta.contains_pii:true, but this command won't return any saved queries that have this meta key in the config, despite us using configs for other purposes (as documented).

Solution

This PR changes the nodes used by the ConfigSelectorMethod to use all_nodes method instead of configurable_nodes. It's the case that all_nodes in that method are actually configurable.

configurable_nodes method was only used in the ConfigSelectorMethod, so this change renders the method unused so we can remove it.

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@trouze trouze self-assigned this May 16, 2025
@cla-bot cla-bot bot added the cla:yes label May 16, 2025
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link

codecov bot commented May 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.78%. Comparing base (1efad4e) to head (06bfad4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11635      +/-   ##
==========================================
- Coverage   88.85%   88.78%   -0.07%     
==========================================
  Files         197      197              
  Lines       24815    24813       -2     
==========================================
- Hits        22050    22031      -19     
- Misses       2765     2782      +17     
Flag Coverage Δ
integration 85.77% <100.00%> (-0.14%) ⬇️
unit 62.87% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.87% <100.00%> (-0.01%) ⬇️
Integration Tests 85.77% <100.00%> (-0.14%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Extend Eligible Nodes for ConfigSelectorMethod to include Saved Query Nodes
1 participant