Extend Eligible Nodes for ConfigSelectorMethod to include Saved Query Nodes #11635
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #11607
Problem
Today, our ConfigSelectorMethod supports selection from parsed and source nodes only.
As an example, you can do this dbt ls -s config.meta.contains_pii:true, but this command won't return any saved queries that have this meta key in the config, despite us using configs for other purposes (as documented).
Solution
This PR changes the nodes used by the
ConfigSelectorMethod
to useall_nodes
method instead ofconfigurable_nodes
. It's the case thatall_nodes
in that method are actually configurable.configurable_nodes
method was only used in theConfigSelectorMethod
, so this change renders the method unused so we can remove it.Checklist