Skip to content

Add clear functionality to EuiDatePickerRange #8428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ChrisJamesC
Copy link

Summary

Propagate the clear prop from EuiFormControlLayoutDelimited to EuiDatePickerRange so we can clear a date range in a consistent way as for other form elements.

QA

Remove or strikethrough items that do not apply to your PR.

General checklist

  • Browser QA
    • Checked in both light and dark modes
    • Checked in mobile
    • Checked in Chrome, Safari, Edge, and Firefox
    • Checked for accessibility including keyboard-only and screenreader modes
  • Docs site QA
  • Code quality checklist
  • Release checklist
    • A changelog entry exists and is marked appropriately.
    • If applicable, added the breaking change issue label (and filled out the breaking change checklist)
  • Designer checklist
    • If applicable, file an issue to update EUI's Figma library with any corresponding UI changes. (This is an internal repo, if you are external to Elastic, ask a maintainer to submit this request)

Copy link

cla-checker-service bot commented Mar 11, 2025

💚 CLA has been signed

Copy link

👋 Since this is a community submitted pull request, a Buildkite build has not been started automatically. Would an Elastic organization member please verify the contents of this pull request and kick off a build manually?

@github-actions github-actions bot added the community contribution (Don't delete - used for automation) label Mar 11, 2025
@ChrisJamesC ChrisJamesC changed the title Add clear functionality to datepickerrange Add clear functionality to EuiDatePickerRange Mar 11, 2025
@weronikaolejniczak
Copy link
Contributor

Hey @ChrisJamesC 👋🏻 what's the status of this PR? Do you need any guidance? 😄 Let me know and thank you for contributing!

@ChrisJamesC
Copy link
Author

ChrisJamesC commented Apr 24, 2025

Hi @weronikaolejniczak, thanks for reaching out.
Given the limited scope of the change I'm not sure how much of the checklist I must go through.

@ChrisJamesC ChrisJamesC marked this pull request as ready for review April 24, 2025 13:31
@ChrisJamesC ChrisJamesC requested a review from a team as a code owner April 24, 2025 13:31
@weronikaolejniczak
Copy link
Contributor

@ChrisJamesC here are some things we'd need to do:

  • add a changelog (you can refer to our wiki)
  • add a unit test for clearing EuiDatePickerRange
  • verify the prop is available as a control in Storybook

You can strikethrough any other checklist element.

If this PR is coming out of a feature request, let's mention it in the description (preferably with closing keywords).

Let me know once you've done the changes and I'll test. And if you need any help, don't hesitate to reach out 😄

@weronikaolejniczak
Copy link
Contributor

Hey @ChrisJamesC 👋🏻 let me know if you need any guidance on moving this PR forward!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community contribution (Don't delete - used for automation)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants