Add local JavaScript test runner #7838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iHiD
commented
May 15, 2025
app/commands/submission/create.rb
Outdated
| Submission::TestRun::Init.(submission) | ||
| def handle_test_run! | ||
| if test_results_json | ||
| Submission::TestRun::Process.(FauxToolingJob.new(submission, test_results_json)) |
There was a problem hiding this comment.
Suggested change
| Submission::TestRun::Process.(FauxToolingJob.new(submission, test_results_json)) | |
| Submission::TestRun::Process.defer(FauxToolingJob.new(submission, test_results_json)) |
iHiD
commented
May 19, 2025
iHiD
changed the title
iHiD
commented
May 20, 2025
app/commands/submission/create.rb
Outdated
| def init_test_run! | ||
| Submission::TestRun::Init.(submission) | ||
| def handle_test_run! | ||
| if test_results_json |
There was a problem hiding this comment.
Suggested change
| if test_results_json | |
| if test_results_json.present? |
iHiD
added a commit
that referenced
this pull request
May 23, 2025
* Add local JavaScript test runner (#7838) * Add test_results_json option to submission create * Insert stub test-result json into create testrun link * Fix things up * Add ClientSide test runner proto * Make work * Add local setup files * Wire in `@exercism/javascript-browser-test-runner` * Update app/commands/solution/generate_test_run_config.rb * Refactor slightly * Refactor plugin, organise files better * Update jest transformIgnorePatterns * Make runTestsClientSide more robust * Make submission/create_test green * Fix create_test --------- Co-authored-by: dem4ron <demaaron88@gmail.com> * Fix submitting status as 'grace' (#7864) * Add shims to esbuild * Lazy import runTestsClientSide * Remove esbuild shizzle --------- Co-authored-by: Jeremy Walker <jez.walker@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.