Skip to content

Update GHSA-hf3r-vmrv-7w29.json #5567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

zly123987
Copy link

Updates

  • References
  • Aliases

Comments

@Copilot Copilot AI review requested due to automatic review settings May 20, 2025 06:24
@github-actions github-actions bot changed the base branch from main to zly123987/advisory-improvement-5567 May 20, 2025 06:25
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the withdrawn CBOR advisory by adding a CVE alias and linking to a patch commit.

  • Add CVE-2024-21909 to the aliases array.
  • Insert a new WEB reference pointing to the patch commit.
Comments suppressed due to low confidence (1)

advisories/github-reviewed/2024/01/GHSA-hf3r-vmrv-7w29/GHSA-hf3r-vmrv-7w29.json:44

  • [nitpick] Indentation for this closing brace is inconsistent with other entries; align it with the surrounding array items (6 spaces) to improve readability.
    },

{
"type": "WEB",
"url": "https://github.com/peteroupc/CBOR/commit/28f308a234b9f3afd88699310b08fdb255321da3",
"summary": "This patch commit is on another branch."
Copy link
Preview

Copilot AI May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The summary is vague; consider specifying the exact branch name (e.g., main or release/4.x) so consumers know where to find this patch commit.

Suggested change
"summary": "This patch commit is on another branch."
"summary": "This patch commit is on the 'release/4.x' branch."

Copilot uses AI. Check for mistakes.

@shelbyc
Copy link
Contributor

shelbyc commented May 20, 2025

Hi @zly123987, I'm closing the PR because GHSA-hf3r-vmrv-7w29 has been withdrawn as a duplicate. GHSA-6r92-cgxc-r5fg is the appropriate GHSA ID that is attached to CVE-2024-21909.

@shelbyc shelbyc closed this May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants