QMake: LGTM fail to check QMake projects

[patrickelectric]

The documentation says that qmake is supported but such thing does not appears in the build output test.

https://lgtm.com/logs/dfa95438ea1c7edfcd9a7fae74ceda48e88972a4/lang:cpp

[jbj]

Thank you for the report. You're right that our support for QMake is not as complete as our support for similar tools like CMake or autotools. I'll put it on my near-term todo list to make that better. Perhaps it's a matter of trying to run qmake if there's a *.pro file but no Makefile?

In the mean time, I'm trying to add your project with a manual configuration. I'll let you know how that goes.

[jbj]

The manual configuration worked. You can view the project on LGTM here: https://lgtm.com/projects/g/bluerobotics/ping-viewer/alerts/?mode=tree

[patrickelectric]

Thanks @jbj !

I believe that you are right, QMake projects contains projects files (.pro) and project include files (.pri). The Makefile is generated after the qmake command ends.

[jbj]

Autobuild support for QMake is now deployed on lgtm.com.

[patrickelectric]

@jbj I tried with two more projects without success, I also tried with a .lgtm.yaml configuration file, and it's not working.
https://lgtm.com/projects/g/patrickelectric/qgc-test/rev/84d94f2ddb23492e6ededfc016052caed28b1eb4

[jbj]

Unfortunately the project in question has been added as a Python+JavaScript project, and through the public interface you can no longer convince it that it's also a C/C++ project.

I looked at the original log for the C/C++ build, and it fails with this error message:

[2019-05-20 13:30:20] [build] CMake Error at CMakeLists.txt:91 (find_package):
[2019-05-20 13:30:20] [build]   Could not find a configuration file for package "Qt5" that is compatible
[2019-05-20 13:30:20] [build]   with requested version "5.11.2".
[2019-05-20 13:30:20] [build]   The following configuration files were considered but not accepted:
[2019-05-20 13:30:20] [build]     /usr/lib/x86_64-linux-gnu/cmake/Qt5/Qt5Config.cmake, version: 5.11.1

Does it seem right that you've requested at least version 5.11.2? Our build environment is still on Ubuntu Cosmic, which has only version 5.11.1.

[patrickelectric]

Hi @jbj, yes the project specify 5.11.2 in CMake, I'll send a new commit to change that. But, this project is still wip with CMake, qmake is the one that's working right now, that's why I did the lgtm configuration file. I believe that the configuration file should be used somehow and a report of the build system should be reported to help us debug this kind of problems.

Right now is a bit tricky to test lgtm or send PRs to configure projects if forks are not allowed to run.

Besides that, it appears that it's not detecting projects or existing projects as candidates to run with qmake.

[patrickelectric]

I can also create a minimal qmake project in github for you if you want to test it with lgtm.

[jbj]

The LGTM autobuilder prefers CMake over QMake when both are possible, so you're right that a .lgtm.yml was needed. I've triggered a new attempt of the C/C++ build of qgc-test, and I'll let you know how that goes.

[jbj]

The build failed because your .lgtm.yml doesn't have the right command to build the project. I get the error You must use shadow build (e.g. mkdir build; cd build; qmake ../qgroundcontrol.pro).

It turns out I can't override the .lgtm.yml in the repo, so try changing it to have the contents below and let me know when that's done. You can also delete .lgtm.yml for now, and then I can attempt a build with a custom one.

extraction:
  cpp:
    configure:
      command:
      - "mkdir _lgtm_build_dir"
      - "cd _lgtm_build_dir"
      - "qmake ../qgroundcontrol.pro"

The reason I'm using the name _lgtm_build_dir for the build dir is that the autobuilder will do make from that directory if it exists.

[patrickelectric]

Great ! Thank you for catching that ! I just did the update in the lgtm file, hope to get that working soon and help the Qt community to use lgtm :)

…

On Wed, May 22, 2019 at 7:06 PM Jonas Jensen ***@***.***> wrote: The build failed because your .lgtm.yml doesn't have the right command to build the project. I get the error <https://github.com/patrickelectric/qgc-test/blob/66a31cec67ba130240c4bb19a8b5cdc00d0ecae9/qgroundcontrol.pro#L13> You must use shadow build (e.g. mkdir build; cd build; qmake ../ qgroundcontrol.pro). It turns out I can't override the .lgtm.yml in the repo, so try changing it to have the contents below and let me know when that's done. You can also delete .lgtm.yml for now, and then I can attempt a build with a custom one. extraction: cpp: configure: command: - "mkdir _lgtm_build_dir" - "cd _lgtm_build_dir" - "qmake ../qgroundcontrol.pro" The reason I'm using the name _lgtm_build_dir for the build dir is that the autobuilder will do make from that directory if it exists. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1230>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAJIYCK52WS6QHWKP6F6FPDPWW7U7ANCNFSM4HE4A5MQ> .

-- Patrick José Pereira Electronics Engineer Skype: patrickelectric434 IRC: patrickelectric +55 (048) 99917-4777