cpp: FPs in Microsoft.SAL

[tosmolka]

We noticed false positives when testing SAL annotations.

These three should demonstrate the issue:
sal.h:

#define _SAL_VERSION 20

test.cpp:

#include "sal.h"
int method1() {
    return _SAL_VERSION;
}
void method2();

test.ql:

import Microsoft.SAL
from SALAnnotation a
select a, a.getDeclaration()

Output from the query:

| test.cpp:3:12:3:23 | _SAL_VERSION | test.cpp:5:6:5:12 | method2 |

It seems the detection is based on "rank" and the fact that MacroInvocation _SAL_VERSION is before DeclarationEntry method2.

Not sure what is the best fix, can you please advise? Thank you.

[jbj]

I'll look into this Monday and get back to you.

[jbj]

Thanks for the report. I'm working on a fix that I'll try to get out this week. Essentially, I want to break the association of SAL elements not only at start positions of declaration entries but also at end positions of their bodies.

[jbj]

I've opened a PR for the fix in the Microsoft-internal repo. When that's merged, it can migrate out to this repo.

[AlexTereshenkov]

@tosmolka it's been a year since you've reported this issue. Does the false positive still persist or was it fixed?

[jbj]

The fix has finally made it back to this repo (in #2151).