LGTM.com - false positive - may not be initialized properly as subclass.init is not called

[LefterisJP]

Description of the false positive

In some cases with multiple inheritance specifying explicity the subclasses constructors to be called is indeed something that has to be done. But there is also cases, such as in our case with Mixins, or if all subclasses are designed for cooperative inheritance where it's fine.

An SO answer that explains that nicely is here: https://stackoverflow.com/a/50465583/110395

URL to the alert on the project page on LGTM.com

https://lgtm.com/projects/g/rotki/rotki/snapshot/54e0a044f538483e949bd3ee4257951a3257bb57/files/rotkehlchen/chain/ethereum/modules/nfts.py?sort=name&dir=ASC&mode=heatmap#xa5976187fed4d9c9:1

[aeisenberg]

Thanks for reporting this false positive. Our current focus is on improving our security analysis. Because your report does not relate to a security query, we will put this on our backlog and prioritize it if we get enough reports of the same underlying issue in other projects. If you think that your report is related to our security analysis, please clarify that in a comment. Either way, we'll let you know here as soon as it's fixed!

[LefterisJP]

No worries. No it's not security related.

But one question @aeisenberg. I added # lgtm [py/missing-call-to-init] in the offending line:
https://github.com/rotki/rotki/pull/3480/files#diff-bb145e1b64be143ffdbce8828716883b00c2bd5f7d4c4aa621bf896021f05870R40

And despite that when the commit was pushed LGTM still complained: rotki/rotki#3480 (comment)

Any idea why? From memory I think this may have happened before with some warnings. Am I doing it wrong or is there something broken?

[intrigus-lgtm]

If you've enabled automated code review of pull requests for your projects, it's important to note that alert suppression changes made in a pull request are only applied when that pull request is merged. So, if you suppress an alert in a pull request, LGTM will continue to report the related alert for as long as the pull request is open.

https://lgtm.com/help/lgtm/alert-suppression

The reason for this is that we don't want an introduction of a bug being unnoticed if a contributor excludes it in the same pull request.