Skip to content

Switch base endpoint to github.ai #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025

Conversation

sgoedecke
Copy link
Contributor

https://github.com/github/models-gateway/issues/361

There are some changes to the notebook metadata/etc that appeared when I ran them for testing. I think it's fine to commit these.

@Copilot Copilot AI review requested due to automatic review settings April 28, 2025 02:03
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the base endpoint from "https://models.inference.ai.azure.com" to "https://models.github.ai/inference" and revises model naming conventions across JavaScript samples and Python cookbooks. Key changes include updating endpoint URLs, modifying model identifier strings (e.g. from "gpt-4o-mini" to "openai/gpt-4o-mini" and various mistralai model names), and adjusting notebook metadata such as kernelspec display names and execution counts.

Reviewed Changes

Copilot reviewed 42 out of 49 changed files in this pull request and generated no comments.

Show a summary per file
File Description
samples/js/azure_ai_inference/chat_with_image_file.js Updated endpoint URL and model name formatting.
samples/js/azure_ai_inference/basic.js Updated endpoint URL and model name; streamlined comments.
cookbooks/python/openai/*.ipynb Updated base URL, model identifier, and notebook metadata.
cookbooks/python/mistralai/*.ipynb Updated endpoint and mistralai model names (with some inconsistencies).
cookbooks/python/llamaindex/rag_getting_started.ipynb Updated kernelspec display name.
cookbooks/python/langchain/lc_openai_getting_started.ipynb Updated endpoint, model name, and kernelspec display name.
Files not reviewed (7)
  • cookbooks/python/openai/data/hotel_invoices/transformed_invoice_json/transformed_hampton_20190411_extracted.json: Language not supported
  • cookbooks/python/openai/data/hotel_invoices/transformed_invoice_json/transformed_madison-502875_extracted.json: Language not supported
  • cookbooks/python/openai/data/hotel_invoices/transformed_invoice_json/transformed_madison_folio_g_cp_efolio5895707_extracted.json: Language not supported
  • samples/curl/basic.sh: Language not supported
  • samples/curl/image_sample.sh: Language not supported
  • samples/curl/multi_turn.sh: Language not supported
  • samples/curl/streaming.sh: Language not supported
Comments suppressed due to low confidence (1)

cookbooks/python/mistralai/evaluation.ipynb:33

  • The global default model name is set to 'mistral-ai/mistral-large', but later the run_mistral() function uses 'mistral-ai/mistral-small' as the default. Consider unifying the default model specification for consistency.
model_name = "mistral-ai/mistral-large"

Copy link
Member

@maraisr maraisr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✨

@sgoedecke sgoedecke merged commit 08ae7f3 into main Apr 28, 2025
@sgoedecke sgoedecke deleted the sgoedecke/switch-base-endpoint-to-github-dot-ai branch April 28, 2025 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants