Rename template file to have .tt extension

[mgriffin]

CodeQL is giving out that one file can't be scanned, and looking at the latest job run, these are the lines that jump out about it:

2025-06-09T09:12:02.4788335Z [2025-06-09 09:12:02] [build-stdout] [2025-06-09 09:12:02] [build-stdout] �[33m WARN�[0m /home/runner/work/github-ds/github-ds/lib/generators/github/ds/templates/migration.rb:1: A parse error occurred. Check the syntax of the file. If the file is invalid, correct the error or exclude the file from analysis.
2025-06-09T09:12:02.4792060Z [2025-06-09 09:12:02] [build-stdout] [2025-06-09 09:12:02] [build-stdout] �[33m WARN�[0m /home/runner/work/github-ds/github-ds/lib/generators/github/ds/templates/migration.rb:1: A parse error occurred. Check the syntax of the file. If the file is invalid, correct the error or exclude the file from analysis.
2025-06-09T09:12:02.4796320Z [2025-06-09 09:12:02] [build-stdout] [2025-06-09 09:12:02] [build-stdout] �[33m WARN�[0m /home/runner/work/github-ds/github-ds/lib/generators/github/ds/templates/migration.rb:3: A parse error occurred. Check the syntax of the file. If the file is invalid, correct the error or exclude the file from analysis.
2025-06-09T09:12:02.4832203Z [2025-06-09 09:12:02] [build-stdout] [2025-06-09 09:12:02] [build-stdout] �[33m WARN�[0m /home/runner/work/github-ds/github-ds/lib/generators/github/ds/templates/migration.rb:3: A parse error occurred. Check the syntax of the file. If the file is invalid, correct the error or exclude the file from analysis.
2025-06-09T09:12:02.4839428Z [2025-06-09 09:12:02] [build-stdout] [2025-06-09 09:12:02] [build-stdout] �[33m WARN�[0m /home/runner/work/github-ds/github-ds/lib/generators/github/ds/templates/migration.rb:4: A parse error occurred. Check the syntax of the file. If the file is invalid, correct the error or exclude the file from analysis.
2025-06-09T09:12:02.4842883Z [2025-06-09 09:12:02] [build-stdout] [2025-06-09 09:12:02] [build-stdout] �[33m WARN�[0m /home/runner/work/github-ds/github-ds/lib/generators/github/ds/templates/migration.rb:10: A parse error occurred. Check the syntax of the file. If the file is invalid, correct the error or exclude the file from analysis.
2025-06-09T09:12:02.4846486Z [2025-06-09 09:12:02] [build-stdout] [2025-06-09 09:12:02] [build-stdout] �[33m WARN�[0m /home/runner/work/github-ds/github-ds/lib/generators/github/ds/templates/migration.rb:10: A parse error occurred. Check the syntax of the file. If the file is invalid, correct the error or exclude the file from analysis.
2025-06-09T09:12:02.4849905Z [2025-06-09 09:12:02] [build-stdout] [2025-06-09 09:12:02] [build-stdout] �[33m WARN�[0m /home/runner/work/github-ds/github-ds/lib/generators/github/ds/templates/migration.rb:11: A parse error occurred. Check the syntax of the file. If the file is invalid, correct the error or exclude the file from analysis.
2025-06-09T09:12:02.4853789Z [2025-06-09 09:12:02] [build-stdout] [2025-06-09 09:12:02] [build-stdout] �[33m WARN�[0m /home/runner/work/github-ds/github-ds/lib/generators/github/ds/templates/migration.rb:11: A parse error occurred. Check the syntax of the file. If the file is invalid, correct the error or exclude the file from analysis.
2025-06-09T09:12:02.4857443Z [2025-06-09 09:12:02] [build-stdout] [2025-06-09 09:12:02] [build-stdout] �[33m WARN�[0m /home/runner/work/github-ds/github-ds/lib/generators/github/ds/templates/migration.rb:13: A parse error occurred. Check the syntax of the file. If the file is invalid, correct the error or exclude the file from analysis.
2025-06-09T09:12:02.4860900Z [2025-06-09 09:12:02] [build-stdout] [2025-06-09 09:12:02] [build-stdout] �[33m WARN�[0m /home/runner/work/github-ds/github-ds/lib/generators/github/ds/templates/migration.rb:13: A parse error occurred. Check the syntax of the file. If the file is invalid, correct the error or exclude the file from analysis.
2025-06-09T09:12:02.4879284Z [2025-06-09 09:12:02] [build-stdout] [2025-06-09 09:12:02] [build-stdout] �[33m WARN�[0m /home/runner/work/github-ds/github-ds/lib/generators/github/ds/templates/migration.rb:17: A parse error occurred. Check the syntax of the file. If the file is invalid, correct the error or exclude the file from analysis.
2025-06-09T09:12:02.4882831Z [2025-06-09 09:12:02] [build-stdout] [2025-06-09 09:12:02] [build-stdout] �[33m WARN�[0m /home/runner/work/github-ds/github-ds/lib/generators/github/ds/templates/migration.rb:17: A parse error occurred. Check the syntax of the file. If the file is invalid, correct the error or exclude the file from analysis.

They point to lib/generators/github/ds/templates/migration.rb and I think it's the ERB code included that's tripping it up. I'm trying out renaming the template file to have a .tt extension, like other Rails generator templates do to see if it cleans up the CodeQL output.

[mgriffin]

Nice, that seems to have worked for CodeQL at least:

Analysis produced the following metric data:

|                            Metric                            | Value |
+--------------------------------------------------------------+-------+
| Total number of Ruby files that were extracted without error |    25 |
| Total number of Ruby files that were extracted with errors   |     0 |

Previously, the output looked like this:

Analysis produced the following metric data:

|                            Metric                            | Value |
+--------------------------------------------------------------+-------+
| Total number of Ruby files that were extracted without error |    25 |
| Total number of Ruby files that were extracted with errors   |     1 |

[mgriffin]

After some local testing, I think the migration to change the ID column to a bigint can be removed (8c383ae) because that's the default value for the ID column in Rails now (except for SQLite)

[Copilot]

Pull Request Overview

This PR renames the migration template to use a .tt extension and updates the Rails generator to reference the new file name, aiming to resolve CodeQL parse errors.

• Rename migration.rb template to migration.rb.tt
• Update migration_template call to point to the new .tt file
• Clean up stray whitespace in the template

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
lib/generators/github/ds/templates/migration.rb.tt	Renamed template file to .tt and removed extra lines
lib/generators/github/ds/active_record_generator.rb	Updated migration_template call to use .tt file

Comments suppressed due to low confidence (2)

lib/generators/github/ds/templates/migration.rb.tt:11

• Removing the change_column call means the id column type will no longer be altered. If the migration should still adjust the primary key to bigint, restore this line or document why it was removed.

change_column  <%= table_name %>, :id, "bigint(20) NOT NULL AUTO_INCREMENT"

[joelhawksley]

How long has this been the Rails default? I think we should restrict which Rails versions we support in the gemspec if we're going to go this route.

[mgriffin]

It looks like this was changed in Rails 6.0, in rails/rails#26266.

I'll go ahead and restrict the Rails version that we support in #72

[joelhawksley]

Sounds good, let's be sure to land #72 before this PR.