-
Notifications
You must be signed in to change notification settings - Fork 3
Open Source required steps #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small nit inline that I think is worth fixing. Thanks for preparing this!
I have pushed a set of changes, so we can run the linter in every pull and locally The action is complaining:
However, this variable annotation seems properly annotated:
Will take a look ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request tries to complete all the steps required to release the library as an Open Source project. The different tasks that need to be performed are described in this issue.
Please, not that some of them do not apply to this project, like
Since this is not a production system but a library that will be used by other people to build their final services.
Once this pull request is approved and merged, I will rewrite the history to have a single commit and will Open an issue in github/security-iam in order to make the repository public